-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
__version__
attribute no longer available
#384
Comments
It does look to me like an accidental API change by a Ruff autofixer, as the commit message just indicates linter fixes, and the API change was mixed in with many other safe changes, making it hard to notice. |
Yes, this was an oversight. I'm afk this week, will make a fix release early next week. |
Wonderful, thank you! |
@mfisher87, @blink1073 it seems you fixed the issue, but I am not sure. What would be the process to reflect the changes? I ran
Thanks |
The fix is not in quite yet, it's in open PR #386. It also adds a test and some other config to avoid regression 💯 To test if you are impacted by this issue, run Unimpacted
Impacted (5.6.0)
|
The bug was introduced in 5.5.1, and will be fixed in 5.6.1. |
It seems the issue was fixed. I usually do: |
|
It seems like
__version__
has been removed from the main namespace in jupyter_core 3.6. I have noted that this had led to issues in at least two other applications that rely on being able to read the version number from__version__
, see conda-forge/quarto-feedstock#34 (comment) and https://gitlab.com/joelostblom/session_info/-/issues/14 for details. Would it be possible to reintroduce the__version__
attribute (or at least mark it as deprecated for a while), or is there a reason for not using it any longer? From my understanding it is more common to have__version__
as an attribute on the main module rather than in aversion.__version__
submodule, but there might very well be good reasons for the latter that I am not aware of.I believe it happened in this PR #376 so cc @blink1073.
The text was updated successfully, but these errors were encountered: