requirements-dev shouldn't depend on pinned requirements.txt

jupyter · Aug 22, 2022 · 3a56973 · 3a56973
1 parent 5556d13
commit 3a56973
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml
@@ -23,10 +23,16 @@ jobs:
         with:
           python-version: ${{ matrix.python }}
 
+      - name: install apt packages
+        # pycurl build requirements
+        run: |
+          sudo apt-get update && sudo apt-get -y install \
+              libcurl4-gnutls-dev \
+              libgnutls28-dev
+
       - name: install
         run: |
-          sudo apt-get -y install libcurl4-gnutls-dev
-          python3 -m pip install -r requirements-dev.txt
+          python3 -m pip install -r requirements.in -r requirements-dev.txt
 
       - name: pip freeze
         run: |

diff --git a/Dockerfile b/Dockerfile
@@ -14,7 +14,6 @@ RUN apt-get update \
     npm
 
 # Build requirements
-COPY ./requirements.txt  /srv/nbviewer/
 COPY ./requirements-dev.txt  /srv/nbviewer/
 RUN python3 -mpip install -r /srv/nbviewer/requirements-dev.txt
 

diff --git a/requirements-dev.txt b/requirements-dev.txt
@@ -1,4 +1,3 @@
--r requirements.txt
 coverage
 invoke>=0.13.0
 mock>=1.3.0  # python34 and older versions of mock do not play well together.