Skip to content

Commit

Permalink
[pre-commit.ci] auto fixes from pre-commit.com hooks
Browse files Browse the repository at this point in the history
for more information, see https://pre-commit.ci
  • Loading branch information
pre-commit-ci[bot] committed Apr 7, 2023
1 parent fd318d1 commit b3663ca
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 4 deletions.
14 changes: 10 additions & 4 deletions binderhub/builder.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
from tornado.iostream import StreamClosedError
from tornado.log import app_log
from tornado.queues import Queue
from tornado.web import Finish, authenticated, HTTPError
from tornado.web import Finish, HTTPError, authenticated

from .base import BaseHandler
from .build import ProgressEvent
Expand Down Expand Up @@ -411,15 +411,21 @@ async def get(self, provider_prefix, _unescaped_spec):
require_build_only = self.settings.get("require_build_only", False)
build_only = False
if not require_build_only:
build_only_query_parameter = self.get_query_argument(name="build_only", default="")
build_only_query_parameter = self.get_query_argument(
name="build_only", default=""
)
if build_only_query_parameter.lower() == "true":
raise HTTPError(log_message="Building but not launching is not permitted!")
raise HTTPError(
log_message="Building but not launching is not permitted!"
)
else:
# Not setting a default will make the function raise an error
# if the `build_only` query parameter is missing from the request
build_only_query_parameter = self.get_query_argument(name="build_only")
if build_only_query_parameter.lower() != "true":
raise HTTPError(log_message="The `build_only=true` query parameter is required!")
raise HTTPError(
log_message="The `build_only=true` query parameter is required!"
)
# If we're here, it means a build only deployment is required
build_only = True

Expand Down
1 change: 1 addition & 0 deletions binderhub/tests/test_build.py
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,7 @@ async def test_build_no_launch(app):
r.raise_for_status()
assert r.reason == "Building but not launching is not permitted!"


def _list_image_builder_pods_mock():
"""Mock list of DIND pods"""
mock_response = mock.MagicMock()
Expand Down

0 comments on commit b3663ca

Please sign in to comment.