Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing additional args to repo2docker #1765

Closed
yuvipanda opened this issue Oct 4, 2023 · 0 comments · Fixed by #1766
Closed

Allow passing additional args to repo2docker #1765

yuvipanda opened this issue Oct 4, 2023 · 0 comments · Fixed by #1766

Comments

@yuvipanda
Copy link
Collaborator

There's no way for us to configure binderhub to allow passing additional args to repo2docker. This is helpful when used with #1647 for example - I wanna pass repo_dir to be /srv/repo, as when used with a persistent home directory $HOME is overriden with persistent directory. Instead of adding each possible option, we should just allow a passthrough.

This is only configured by admins setting up binderhub, not end users.

yuvipanda added a commit to yuvipanda/binderhub that referenced this issue Oct 6, 2023
Very helpful for a specific binderhub instance to customize
how images are built. Off the top of my head, two useful things
would be to pass `--repo-dir` (so you can have this work with
a persistent home directory but still get access to the files in
the image), and `--base-image` (so an install can use a different
base image than rep2docker default).

As it's a simple passthrough, I've added a unit test only (no
integration test).

Fixes jupyterhub#1765
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant