-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow building the image without needing to launch it #1647
Merged
Merged
Changes from all commits
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
a5a13ec
Empty dummy commit to allow a draft PR to be created
consideRatio bb910cd
Add the traitlet option and check query param with same name
GeorgianaElena 2ed3e8b
Update api exaple to support option
GeorgianaElena 4a11638
No need for fstrings
GeorgianaElena 008cc34
Try out a test
GeorgianaElena 3505fcb
Update messages emmited
GeorgianaElena 5ec3c5a
Use the ready phase to signal end of ops
GeorgianaElena bc8f68c
Make the no_launch option configurable
GeorgianaElena 5987b4e
Add no_launch to local testing config
GeorgianaElena dc9b84b
Rename configs and change logic
GeorgianaElena 835a43b
Change error type
GeorgianaElena fbdf0c6
Update examples
GeorgianaElena 3c310e9
Update initial test
GeorgianaElena 27c2944
Remove unused import
GeorgianaElena 0aff6a8
Update messages and logic to preserve old ones but also be explicit a…
GeorgianaElena e67a84b
Update one more message
GeorgianaElena b80eaf7
Add more test for failing cases
GeorgianaElena 97cabe3
Add missing config
GeorgianaElena 0edd782
Test with build_only true
GeorgianaElena 7f5156b
Allow for build_only configured app fixture in all kind of tests
GeorgianaElena dabfb6d
Do not mark tests remote as we cannot configure binderhub with the de…
GeorgianaElena 1f4db5f
_binderhub_config fixture has a session scope
GeorgianaElena 2f0e3ce
Add more comments and do some cleanup
GeorgianaElena 09da08d
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 3a43d8e
Only test one situation as running this test is toily
GeorgianaElena ff0670c
Put the fixtures back into the tests as they're needed
GeorgianaElena fc84a66
Move logic about determining the build only action into its own function
GeorgianaElena fb008c8
Move the eval table to the tratilet help string
GeorgianaElena 19d45bd
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 96188ed
Add note about not supporting build only UI|
GeorgianaElena f53636a
Add fixtture to ensure no builds are tried when not available
GeorgianaElena 702c57a
Render an error page when the build UI is accesed and require_build_o…
GeorgianaElena a7d2418
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 252987c
Just deactivate the / and /v2 endpoints when require_build_only is True
GeorgianaElena 0203a2d
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 15dc9d3
Update build success metrics even if we don't launch after
GeorgianaElena f3d174b
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] c20ca53
Fix indentation
GeorgianaElena f7a4c3c
Replace require_build_only for a more clear enable_api_only_mode config
GeorgianaElena 5cf641d
Update how we decide if build only mode was activated
GeorgianaElena 61d1a5d
Get the Custom404 handler in both cases
GeorgianaElena 08d4f1d
update message
GeorgianaElena 368cad7
Update the test config
GeorgianaElena 693baf9
Update tests
GeorgianaElena b2925dc
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 6252eb6
Updat log message and assert
GeorgianaElena 114b195
Drop the outcome suffix for clariry and specify a status code for the…
GeorgianaElena d5f686d
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This lacks a status code. Presumably it should be
400
?