Guarantee that badge_base_url will always have a trailing / #1779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this, the callable could return something without a trailing slash, and that could break things.
yuvipanda
added
code:python
GeorgianaElena
approved these changes
Oct 17, 2023
consideRatio
approved these changes
Oct 18, 2023
consideRatio
added
maintenance
consideRatio
pushed a commit
to jupyterhub/helm-chart
that referenced
this pull request
Oct 18, 2023
jupyterhub/binderhub#1779 Merge pull request #1779 from yuvipanda/base_url_trailing_slash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this, the callable could return something without a
trailing slash, and that could break things.