From 0218628c323f139c2d1ec6edc430437c1f835739 Mon Sep 17 00:00:00 2001 From: jnywong Date: Mon, 27 May 2024 12:11:20 +0000 Subject: [PATCH 1/2] Add warning for image-tests when using DockerFile --- README.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/README.md b/README.md index 0f662fb..35b5db0 100644 --- a/README.md +++ b/README.md @@ -116,6 +116,9 @@ run any Jupyter Notebooks as tests. This **works with any Jupyter kernel**. This action will use the Jupyter kernel defined in any notebook you put in `image-tests/`. This can be used to execute and test notebooks from any language. +> [!WARNING] +> If you are using a Dockerfile to configure your environment, then include `COPY --chown=${NB_USER}:${NB_USER} image-tests /srv/repo/image-tests` in your Dockerfile to ensure the correct ownership of this folder within the image. + To use automatic image testing, follow these steps: 1. Create a directory named `image-tests/` in your GitHub repository. From a8c374c9fce0df409d829514a7f0c94c15c6b649 Mon Sep 17 00:00:00 2001 From: Yuvi Panda Date: Mon, 27 May 2024 10:30:58 -0700 Subject: [PATCH 2/2] Copy file into REPO_DIR --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 35b5db0..e31374b 100644 --- a/README.md +++ b/README.md @@ -117,7 +117,7 @@ run any Jupyter Notebooks as tests. This **works with any Jupyter kernel**. This action will use the Jupyter kernel defined in any notebook you put in `image-tests/`. This can be used to execute and test notebooks from any language. > [!WARNING] -> If you are using a Dockerfile to configure your environment, then include `COPY --chown=${NB_USER}:${NB_USER} image-tests /srv/repo/image-tests` in your Dockerfile to ensure the correct ownership of this folder within the image. +> If you are using a Dockerfile to configure your environment, then include `COPY --chown=${NB_USER}:${NB_USER} image-tests ${REPO_DIR}/image-tests` in your Dockerfile to ensure the correct ownership of this folder within the image. To use automatic image testing, follow these steps: