Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document that you need to copy image-tests into the docker image yourself if using a DockerFile #123

Closed
jnywong opened this issue May 27, 2024 · 0 comments · Fixed by #124
Closed

Document that you need to copy image-tests into the docker image yourself if using a DockerFile #123

jnywong opened this issue May 27, 2024 · 0 comments · Fixed by #124

Comments

@jnywong
Copy link
Contributor

jnywong commented May 27, 2024

@batpad @sunu I think if sunu/ghg-workshop-python-image#1 passes tests, then we can add documentation to https://github.com/jupyterhub/repo2docker-action?tab=readme-ov-file#testing-the-built-image to the effect of:

  1. If you're using a Dockerfile, you need to copy image-tests into the docker image yourself
  2. You have to make sure the ownership of that is 'correct', and suggest using COPY --chown for that

Originally posted by @yuvipanda in #111 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add warning for image-tests when using DockerFile jnywong/repo2docker-action
1 participant
@jnywong