Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update master branch references to main where suitable #115

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

consideRatio
Copy link
Member

@consideRatio consideRatio commented Mar 24, 2024

This is the first step to renaming from master to main, approve and I'll get the rest done.

Copy link
Collaborator

@yuvipanda yuvipanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, @consideRatio!

I'm very much in favor :)

The one question I have is - does this mean that downstream users of this action would need to rename master to main in their actions? or is the compatibility / rename layer take care of that?

@consideRatio
Copy link
Member Author

The one question I have is - does this mean that downstream users of this action would need to rename master to main in their actions? or is the compatibility / rename layer take care of that?

I expect this to work for anyone referencing master still, but I'm not 100% confident. I suggest we test and see, and think about how to handle it otherwise.

@consideRatio consideRatio merged commit 762096f into jupyterhub:master Mar 26, 2024
24 of 72 checks passed
@consideRatio
Copy link
Member Author

Blah... hmmm...

Error: Unable to resolve action `jupyterhub/repo2docker-action@master`, unable to find version `master`

@consideRatio
Copy link
Member Author

consideRatio commented Mar 26, 2024

I think the options, like providing a mirrored branch, or providing a moving tag master always pointing to main's HEAD are too messy - reverting this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants