refactor: use list comprehension rather filter+lambda

jupyterhub · Oct 31, 2022 · 2e5e3c0 · 2e5e3c0
1 parent 95b5ace
commit 2e5e3c0
Showing 1 changed file with 11 additions and 9 deletions.
diff --git a/repo2docker/buildpacks/base.py b/repo2docker/buildpacks/base.py
@@ -589,16 +589,18 @@ def _filter_tar(tarinfo):
 
         exclude = []
 
-        for ignore_file in [".dockerignore", ".containerignore"]:
-            if os.path.exists(ignore_file):
-                with open(ignore_file, "r") as f:
+        for ignore_file_name in [".dockerignore", ".containerignore"]:
+            if os.path.exists(ignore_file_name):
+                with open(ignore_file_name, "r") as ignore_file:
+                    cleaned_lines = [
+                        line.strip() for line in ignore_file.read().splitlines()
+                    ]
                     exclude.extend(
-                        list(
-                            filter(
-                                lambda x: x != "" and x[0] != "#",
-                                [l.strip() for l in f.read().splitlines()],
-                            )
-                        )
+                        [
+                            line
+                            for line in cleaned_lines
+                            if line != "" and line[0] != "#"
+                        ]
                     )
 
         if not exclude: