Skip to content

Commit

Permalink
pytest: replace fspath with path
Browse files Browse the repository at this point in the history
  • Loading branch information
manics committed Jan 28, 2024
1 parent 3505ad7 commit 6fe9ee6
Showing 1 changed file with 9 additions and 9 deletions.
18 changes: 9 additions & 9 deletions tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,9 @@

def pytest_collect_file(parent, path):
if path.basename == "verify":
return LocalRepo.from_parent(parent, fspath=path)
return LocalRepo.from_parent(parent, path=path)
elif path.basename.endswith(".repos.yaml"):
return RemoteRepoList.from_parent(parent, fspath=path)
return RemoteRepoList.from_parent(parent, path=path)


def make_test_func(args, skip_build=False, extra_run_kwargs=None):
Expand Down Expand Up @@ -213,7 +213,7 @@ def __init__(
super().__init__(name, parent, callobj=f)

def reportinfo(self):
return (self.parent.fspath, None, "")
return (self.parent.path, None, "")

def repr_failure(self, excinfo):
err = excinfo.value
Expand All @@ -233,24 +233,24 @@ def collect(self):
args = ["--appendix", 'RUN echo "appendix" > /tmp/appendix']
# If there's an extra-args.yaml file in a test dir, assume it contains
# a yaml list with extra arguments to be passed to repo2docker
extra_args_path = os.path.join(self.fspath.dirname, "test-extra-args.yaml")
extra_args_path = os.path.join(self.path.dirname, "test-extra-args.yaml")
if os.path.exists(extra_args_path):
with open(extra_args_path) as f:
extra_args = yaml.safe_load(f)
args += extra_args

print(self.fspath.basename, self.fspath.dirname, str(self.fspath))
print(self.path.basename, self.path.dirname, str(self.path))
# re-use image name for multiple tests of the same image
# so we don't run through the build twice
rel_repo_dir = os.path.relpath(self.fspath.dirname, TESTS_DIR)
rel_repo_dir = os.path.relpath(self.path.dirname, TESTS_DIR)
image_name = f"r2d-tests-{escapism.escape(rel_repo_dir, escape_char='-').lower()}-{int(time.time())}"
args.append(f"--image-name={image_name}")
args.append(self.fspath.dirname)
args.append(self.path.dirname)
yield Repo2DockerTest.from_parent(self, name="build", args=args)

yield Repo2DockerTest.from_parent(
self,
name=self.fspath.basename,
name=self.path.basename,
args=args + ["./verify"],
skip_build=True,
)
Expand All @@ -273,7 +273,7 @@ def collect(self):

class RemoteRepoList(pytest.File):
def collect(self):
with self.fspath.open() as f:
with self.path.open() as f:
repos = yaml.safe_load(f)
for repo in repos:
args = []
Expand Down

0 comments on commit 6fe9ee6

Please sign in to comment.