Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update versioneer #1329

Merged
merged 3 commits into from
Jan 28, 2024
Merged

Update versioneer #1329

merged 3 commits into from
Jan 28, 2024

Conversation

TimoRoth
Copy link
Contributor

Installing repo2docker on an up to date python version fails with various errors in these files.
This PR is simply the result of running "versioneer install" with the latest versioneer version.

@manics
Copy link
Member

manics commented Jan 28, 2024

It looks like pre-commit is causing problems. Can you try installing and running it locally?

pip install pre-commit
pre-commit run -a
git add -u
git commit ...

@TimoRoth
Copy link
Contributor Author

TimoRoth commented Jan 28, 2024

This somehow made pre-commit happy, after it commited a few more changes via the Workflow, but now all the tests are failing with that looks an unrelated error on first glance.

Oh, pytest 8.0.0 just released, and it seems to be what's breaking the tests.

@manics manics mentioned this pull request Jan 28, 2024
@manics
Copy link
Member

manics commented Jan 28, 2024

Thanks! Given that the failure is unrelated, the tests were passing, and it's going to break our main branch regardless, I'll merge this.

@manics manics merged commit 6f92fa0 into jupyterhub:main Jan 28, 2024
9 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants