Remove support for deprecated Julia REQUIRE, Julia < 1.3 #1350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the oldest version of ZMQ.jl that doesn't rely on the removed repo requires Julia 1.3, starting with JuliaInterop/ZMQ.jl#194 . So now Julia 1.3 is the oldest version we can support. |
it doesn't work anymore because build dependencies of the old ZMQ.jl have been removed.
minrk
changed the title
|
in fact, 1.3-1.5 fail with "No Such Device" in the precompile bind here: ZMQ.bind(s1, "tcp://localhost:*")so as it is now, only Julia >= 1.6 will actually work. The precompile on 1.3-1.5 should be fixed by JuliaInterop/ZMQ.jl#237 |
|
It would probably behoove us to have frozen base environments for Julia eventually. That wouldn't nave solved the current problem, though. |
manics
approved these changes
May 28, 2024
There was a problem hiding this comment.
Looks good! https://github.com/JuliaInterop/ZMQ.jl/releases/tag/v1.2.5 was released, so if CI passes this can be merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it doesn't work anymore because build dependencies of the old ZMQ.jl have been removed, so I don't see a feasible way for us to keep it working.
xref JuliaInterop/ZMQ.jl#228
closes #1349