Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for mamba 2.0.0rc6 #1366

Closed
wants to merge 30 commits into from
Closed

Update for mamba 2.0.0rc6 #1366

wants to merge 30 commits into from

Conversation

jjerphan
Copy link
Contributor

No description provided.

@jjerphan
Update for mamba 2.0.0rc2
b6936ab 
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
@jjerphan
Use conda 24.7.0
39d0dd5
@jjerphan
Use custom build of conda-libmamba-solver
d404831 
See:
https://anaconda.org/conda-canary/conda-libmamba-solver/files?channel=conda-libmamba-solver-pr-457

Co-authored-by: Hind Montassif <hind.montassif@gmail.com>

Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
@jjerphan jjerphan mentioned this pull request Aug 21, 2024
Merged
jjerphan and others added 2 commits August 21, 2024 15:55
@jjerphan
Update version numbers in tests
6ce813d 
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
@jjerphan @jaimergp
Add explicit specification for conda-libmamba-solver
0567403 
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>

Co-authored-by: jaimergp <jaimergp@users.noreply.github.com>
@jjerphan
Initialize current shell
e4b24a4 
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
@jjerphan
fixup! Initialize current shell
d19609b
@jjerphan
Adapt match specifications
a947a08 
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
jjerphan and others added 5 commits August 22, 2024 11:22
@jjerphan
Remove duplicated call to micromamba shell hook
c19c508
@jjerphan
Explicitly specify the channel of the custom build of conda-libmamba-…
efe36d7 
…solver
@jjerphan @SylvainCorlay @Hind-M
Use micromamba activate instead of mamba activate
0a14433 
The shell macros are only defined for micromamba
but not for mamba.

This brings consistency.

But then, what was making it working before?

Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>

Co-authored-by: Sylvain Corlay <sylvain.corlay@gmail.com>
Co-authored-by: Hind Montassif <hind.montassif@gmail.com>
@jjerphan
Show stdout
d520a64 
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
@jjerphan
Fix version number in tests/conda/py35-binder-dir/verify
47a1561 
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
@Hind-M
Copy link

Hind-M commented Aug 23, 2024

Can you also check that MICROMAMBA_EXE="/usr/local/bin/micromamba" is the right path? at least locally and project?
And we would also need to replace MAMBA_EXE with MICROMAMBA_EXE

@Hind-M
Copy link

Hind-M commented Aug 23, 2024

And maybe remove this so that if we missed places we would have errors.

@Hind-M
Copy link

Hind-M commented Aug 23, 2024 •
edited
Loading

Or we can just set MAMBA_EXE to the same path as MICROMAMBA_EXE instead (less replacement)

@jjerphan @Hind-M
Use micromamba instead of mamba everywhere
ff16804 
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>

Co-authored-by: Hind Montassif <hind.montassif@gmail.com>
@jjerphan
Copy link
Contributor Author

Or we can just set MAMBA_EXE to the same path as MICROMAMBA_EXE instead (less replacement)

Done in ff16804. FYI, MAMBA_EXE has the same value than MICROMAMBA_EXE i.e "/usr/local/bin/micromamba" after the hook is called.

@jjerphan jjerphan changed the title Update for mamba 2.0.0rc2 Update for mamba 2.0.0rc3 Aug 26, 2024
jjerphan and others added 3 commits August 26, 2024 22:11
@jjerphan
Reuse mamba in the activation script
4a02cc3
@jjerphan @SylvainCorlay
Revert to use MAMBA_EXE
14addc5 
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>

Co-authored-by: Sylvain Corlay <sylvain.corlay@gmail.com>
@jjerphan
Use 2.0.0rc4
3d7a7cc 
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
@jjerphan jjerphan changed the title Update for mamba 2.0.0rc3 Update for mamba 2.0.0rc4 Aug 29, 2024
@jjerphan
Do not forward stdout
0a6406c 
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
@jjerphan
Log source of profile
1ebc84e 
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
@jjerphan
Log information of the current environment in py36-postBuild/postBuild
ea83903 
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
@jjerphan @jaimergp
Show all env variables
86ff1fa 
Co-authored-by: jaimergp <jaimergp@users.noreply.github.com>
@jjerphan jjerphan changed the title Update for mamba 2.0.0rc4 Update for mamba 2.0.0rc5 Sep 13, 2024
@jjerphan jjerphan changed the title Update for mamba 2.0.0rc5 Update for mamba 2.0.0rc6 Sep 20, 2024
@jjerphan
Copy link
Contributor Author

Closing as this PR only was meant to test mamba 2.0 release candidates.

@jjerphan jjerphan closed this Sep 26, 2024
@jjerphan jjerphan deleted the update-mamba-2.0.0rc2 branch September 27, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaimergp jaimergp jaimergp left review comments

@Hind-M Hind-M Hind-M left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jjerphan @Hind-M @jaimergp