Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a new phpcs command to run phpcs analysis #28

Merged
merged 8 commits into from
Oct 7, 2024

Conversation

plopesc
Copy link
Contributor

@plopesc plopesc commented Apr 29, 2024

While installing and testing the plugin though that phpcs command could b ea good addition.

If you find it useful, I could work on other code quality commands, like phpstan or eslint.

Thank you for the great job made in this extension.

@justafish
Copy link
Owner

That's cool! Yeah it'd be great to have other commands, and maybe a singular lint to run all the static code analysis tools

Holding off on merging this until I can test it, but it looks good from a glance

@plopesc
Copy link
Contributor Author

plopesc commented Apr 29, 2024

Let me rename this one as lint:phpcs and I'll work on the others in this same MR if you're OK with it.

Copy link
Owner

@justafish justafish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a few small changes and updated the readme - thanks @plopesc !

@justafish justafish merged commit 5fff83a into justafish:main Oct 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants