Skip to content

Commit

Permalink
Labels are not required in attribute options (#2)
Browse files Browse the repository at this point in the history
  • Loading branch information
ramonrietdijk authored Sep 4, 2023
1 parent 90de903 commit 94f2e7a
Show file tree
Hide file tree
Showing 7 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion src/Actions/Akeneo/FormatAttributeValues.php
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ public function format(string $attributeCode, mixed $value): array
return $values;
}

public function value(mixed $data, ?string $scope = null, ?string $locale = null): array
public function value(mixed $data, string $scope = null, string $locale = null): array
{
return [
'data' => $data,
Expand Down
2 changes: 1 addition & 1 deletion src/Data/AttributeOptionData.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ class AttributeOptionData extends Data
'code' => 'required|string',
'attribute' => 'required|string',
'sort_order' => 'required|int',
'labels' => 'required|array',
'labels' => 'array',
];

public function code(): string
Expand Down
2 changes: 1 addition & 1 deletion src/Data/Data.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
use Illuminate\Contracts\Support\Arrayable;
use JustBetter\AkeneoProducts\Concerns\ValidatesData;

abstract class Data implements ArrayAccess, Arrayable
abstract class Data implements Arrayable, ArrayAccess
{
use ValidatesData;

Expand Down
2 changes: 1 addition & 1 deletion src/Jobs/ProcessProductsJob.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
use Illuminate\Queue\InteractsWithQueue;
use JustBetter\AkeneoProducts\Contracts\ProcessesProducts;

class ProcessProductsJob implements ShouldQueue, ShouldBeUnique
class ProcessProductsJob implements ShouldBeUnique, ShouldQueue
{
use Dispatchable;
use InteractsWithQueue;
Expand Down
2 changes: 1 addition & 1 deletion src/Jobs/RetrieveProductJob.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
use Illuminate\Queue\InteractsWithQueue;
use JustBetter\AkeneoProducts\Contracts\RetrievesProduct;

class RetrieveProductJob implements ShouldQueue, ShouldBeUnique
class RetrieveProductJob implements ShouldBeUnique, ShouldQueue
{
use Dispatchable;
use InteractsWithQueue;
Expand Down
2 changes: 1 addition & 1 deletion src/Jobs/SaveProductJob.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
use JustBetter\AkeneoProducts\Contracts\SavesProduct;
use JustBetter\AkeneoProducts\Data\ProductData;

class SaveProductJob implements ShouldQueue, ShouldBeUnique
class SaveProductJob implements ShouldBeUnique, ShouldQueue
{
use Dispatchable;
use InteractsWithQueue;
Expand Down
2 changes: 1 addition & 1 deletion src/Jobs/UpdateProductJob.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
use JustBetter\AkeneoProducts\Models\Product;
use Throwable;

class UpdateProductJob implements ShouldQueue, ShouldBeUnique
class UpdateProductJob implements ShouldBeUnique, ShouldQueue
{
use Dispatchable;
use InteractsWithQueue;
Expand Down

0 comments on commit 94f2e7a

Please sign in to comment.