Merge pull request #5 from justbetter/feature/null-coalescing-assignm…

…ent-operator Added null coalescing assignment operator for the base resource
justbetter · Nov 25, 2022 · 59e7709 · 59e7709
2 parents 2eae734 + 1b25482
commit 59e7709
Show file tree

Hide file tree

Showing 3 changed files with 52 additions and 2 deletions.
diff --git a/src/OData/BaseResource.php b/src/OData/BaseResource.php
@@ -28,8 +28,8 @@ abstract class BaseResource implements ArrayAccess, Arrayable
 
     public function __construct(?string $connection = null, ?string $endpoint = null)
     {
-        $this->connection = $connection ?? config('dynamics.connection');
-        $this->endpoint = $endpoint ?? config('dynamics.resources.'.static::class, Str::afterLast(static::class, '\\'));
+        $this->connection ??= $connection ?? config('dynamics.connection');
+        $this->endpoint ??= $endpoint ?? config('dynamics.resources.'.static::class, Str::afterLast(static::class, '\\'));
     }
 
     public static function new(?string $connection = null, ?string $endpoint = null): static

diff --git a/tests/Fakes/OData/FakeResource.php b/tests/Fakes/OData/FakeResource.php
@@ -0,0 +1,16 @@
+<?php
+
+namespace JustBetter\DynamicsClient\Tests\Fakes\OData;
+
+use JustBetter\DynamicsClient\OData\BaseResource;
+
+class FakeResource extends BaseResource
+{
+    public string $connection = '::fake-connection::';
+
+    public string $endpoint = '::fake-endpoint::';
+
+    public array $primaryKey = [
+        'No',
+    ];
+}
diff --git a/tests/OData/BaseResourceTest.php b/tests/OData/BaseResourceTest.php
@@ -3,6 +3,7 @@
 namespace JustBetter\DynamicsClient\Tests\OData;
 
 use JustBetter\DynamicsClient\OData\Pages\Customer;
+use JustBetter\DynamicsClient\Tests\Fakes\OData\FakeResource;
 use JustBetter\DynamicsClient\Tests\TestCase;
 
 class BaseResourceTest extends TestCase
@@ -11,6 +12,10 @@ protected function setUp(): void
     {
         parent::setUp();
 
+        config()->set('dynamics.resources', [
+            Customer::class => '::customer-endpoint::',
+        ]);
+
         config()->set('dynamics.connections.::default::', [
             'base_url' => '::base_url::',
             'company' => '::company::',
@@ -44,6 +49,14 @@ public function it_can_get_the_default_connection(): void
         $this->assertEquals('::default::', $page->connection);
     }
 
+    /** @test */
+    public function it_can_get_the_default_endpoint(): void
+    {
+        $page = new Customer();
+
+        $this->assertEquals('::customer-endpoint::', $page->endpoint);
+    }
+
     /** @test */
     public function it_can_set_the_connection(): void
     {
@@ -55,4 +68,25 @@ public function it_can_set_the_connection(): void
 
         $this->assertEquals('::other-connection::', $page->connection);
     }
+
+    /** @test */
+    public function it_can_set_the_endpoint(): void
+    {
+        $page = new Customer(null, '::other-endpoint::');
+
+        $this->assertEquals('::other-endpoint::', $page->endpoint);
+
+        $page = Customer::new(null, '::other-endpoint::');
+
+        $this->assertEquals('::other-endpoint::', $page->endpoint);
+    }
+
+    /** @test */
+    public function it_can_force_a_connection_and_endpoint(): void
+    {
+        $resource = FakeResource::new();
+
+        $this->assertEquals('::fake-connection::', $resource->connection);
+        $this->assertEquals('::fake-endpoint::', $resource->endpoint);
+    }
 }