Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nested derived predicates support #109

Closed
justin13601 opened this issue Aug 22, 2024 · 1 comment · Fixed by #117
Closed

Nested derived predicates support #109

justin13601 opened this issue Aug 22, 2024 · 1 comment · Fixed by #117
Labels
Bug Something isn't working Enhancement New feature or request Expand Predicates Scope For issues relating to allowing more complex expressions in predicate configurations priority:critical Things that are critical bug fixes, to be addressed immediately and pushed with minor version update

Comments

@justin13601
Copy link
Owner

Allow derived predicates that are dependent on other derived predicates
@justin13601 justin13601 added Bug Something isn't working Enhancement New feature or request priority:critical Things that are critical bug fixes, to be addressed immediately and pushed with minor version update Expand Predicates Scope For issues relating to allowing more complex expressions in predicate configurations labels Aug 22, 2024
@mmcdermott
Copy link
Collaborator

I'm not yet able to reproduce @Oufattole's original issue that made me think this might be wrong. In branch 109_nested_predicates (see linked branch) I add a config test with a 2-layer setup and it doesn't have any issue, but it may be an insufficient test.

@mmcdermott mmcdermott mentioned this issue Aug 24, 2024
Merged
@mmcdermott mmcdermott linked a pull request Aug 24, 2024 that will close this issue
Tests more deeply nested predicates directly to assess #109 #117
Merged
mmcdermott added a commit that referenced this issue Aug 24, 2024
@mmcdermott
Merge pull request #117 from justin13601/109_nested_predicates
7f49fda 
Tests more deeply nested predicates directly to assess #109
@mmcdermott mmcdermott closed this as not planned Won't fix, can't repro, duplicate, stale Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working Enhancement New feature or request Expand Predicates Scope For issues relating to allowing more complex expressions in predicate configurations priority:critical Things that are critical bug fixes, to be addressed immediately and pushed with minor version update
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tests more deeply nested predicates directly to assess #109 justin13601/ACES
2 participants
@mmcdermott @justin13601