Added more flexibility for expand shards, as well as reading dir as glob #81
Conversation
WalkthroughThe changes to the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant expand_shards
participant Directory
participant ShardProcessor
User->>expand_shards: Call with directory path
expand_shards->>Directory: Check if path is a directory
Directory-->>expand_shards: Return list of files
expand_shards->>User: Return file list as string
User->>expand_shards: Call with shard specification
expand_shards->>ShardProcessor: Validate and expand shards
ShardProcessor-->>expand_shards: Return expanded shards
expand_shards->>User: Return expanded shards as string
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Codecov ReportAttention: Patch coverage is
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- src/aces/expand_shards.py (1 hunks)
Additional context used
GitHub Check: codecov/patch
src/aces/expand_shards.py
[warning] 64-64: src/aces/expand_shards.py#L64
Added line #L64 was not covered by tests
Additional comments not posted (4)
src/aces/expand_shards.py (4)
3-4: LGTM! Imports are appropriate.The new imports for
globandosare necessary for the enhanced functionality of theexpand_shardsfunction.
10-46: LGTM! Docstring is clear and informative.The updated docstring accurately describes the enhanced functionality of the
expand_shardsfunction and provides useful examples.
51-54: LGTM! Directory handling is well-implemented.The new functionality to handle directories using
globis well-implemented.
Line range hint
69-77:
LGTM! Main function is appropriate.The
mainfunction is simple and appropriate for command-line execution.Tools
GitHub Check: codecov/patch
[warning] 64-64: src/aces/expand_shards.py#L64
Added line #L64 was not covered by tests
| match = re.match(r"(.+)([/_])(\d+)$", arg) | ||
| if match: | ||
| prefix = match.group(1) | ||
| delimiter = match.group(2) | ||
| num = int(match.group(3)) | ||
| result.extend(f"{prefix}{delimiter}{i}" for i in range(num)) | ||
| else: | ||
| raise ValueError(f"Invalid shard format: {arg}") |
There was a problem hiding this comment.
Improve shard format validation and test coverage.
The shard format validation currently only handles / and _ as delimiters. Consider expanding this to handle more delimiters if needed. Additionally, the error handling line is not covered by tests.
- match = re.match(r"(.+)([/_])(\d+)$", arg)
+ match = re.match(r"(.+)([/_.-])(\d+)$", arg) # Added `.` and `-` as possible delimitersDo you want me to generate the unit testing code to cover the error handling or open a GitHub issue to track this task?
<details>
<summary>Tools</summary>
<details>
<summary>GitHub Check: codecov/patch</summary><blockquote>
[warning] 64-64: src/aces/expand_shards.py#L64
Added line #L64 was not covered by tests
</blockquote></details>
</details>
<!-- This is an auto-generated comment by CodeRabbit -->
Closes #77
Summary by CodeRabbit
New Features
expand_shardsfunction to support expansion of both shard prefixes and directory paths, listing all files within the specified directory.Bug Fixes
ValueError.