This repository has been archived by the owner on Jun 22, 2021. It is now read-only.
Add support for dynamically matching targets #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a basis protocol (Target) which exposes match? for whether or
not a target matches. A sequential search is then performed over all
targets for each input target.
Example usage of this feature:
```
;; Machfile.edn
{#mach/glob "*.md" {product "somefile"
produce (str "# A title")}}
$ mach hello.md
Writing somefile
```
Further functionality that is necessary to make this feature useful is
the exposure of the match ctx (already assoced onto the target when it
matches) so that code can refer to the full path. To extend the example
above, the future feature should allow the product to be set based on
the matching input.
I haven't thoroughly tested this, so a second pair of eyes over this
would be good.
This binds 2 vars during the evaluation of targets. `mach.core/*target-ctx*` this is bound to a string that contains the whole string that matched this target e.g. a glob fo* would match "foo.xml", this var would contain "foo.xml" `mach.core/*matcher-ctx*` this is bound to the object that was used to match this target. e.g. for `#mach/glob "fo*"` the underlying Glob object will be bound to this var.
SevereOverfl0w
force-pushed
the
genericleft
branch
from
c25db87 to
de30e5e
Compare
|
new commit added which dynamically binds vars relative to the match context. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a basis protocol (Target) which exposes match? for whether or
not a target matches. A sequential search is then performed over all
targets for each input target.
Example usage of this feature:
Further functionality that is necessary to make this feature useful is
the exposure of the match ctx (already assoced onto the target when it
matches) so that code can refer to the full path. To extend the example
above, the future feature should allow the product to be set based on
the matching input.
I haven't thoroughly tested this, so a second pair of eyes over this
would be good.