Fixed bug with connecting detailed signal from builder object

jwharm · Oct 1, 2024 · 6147994 · 6147994
1 parent 88ea2ea
commit 6147994
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/modules/gio/src/test/java/io/github/jwharm/javagi/test/gio/PropertiesTest.java b/modules/gio/src/test/java/io/github/jwharm/javagi/test/gio/PropertiesTest.java
@@ -78,6 +78,9 @@ public void builder() {
         assertEquals(Set.of(ApplicationFlags.IS_SERVICE), app.getFlags());
 
         // Assert that the "notify" signal is connected
+        // only for the specified property
+        assertFalse(notified.get());
+        app.setFlags(ApplicationFlags.DEFAULT_FLAGS);
         assertFalse(notified.get());
         app.setApplicationId("javagi.test.Application2");
         assertTrue(notified.get());

diff --git a/modules/gobject/src/main/java/io/github/jwharm/javagi/gobject/Builder.java b/modules/gobject/src/main/java/io/github/jwharm/javagi/gobject/Builder.java
@@ -110,7 +110,7 @@ public void connect(String name, FunctionPointer callback) {
     @Override
     public void connect(String name, String detail, FunctionPointer callback) {
         boolean isDetailed = detail != null && !detail.isBlank();
-        String fullName = name + (isDetailed ? "" : ("::" + detail));
+        String fullName = name + (isDetailed ? ("::" + detail) : "");
         connectRequests.add(new ConnectRequest(fullName, callback));
     }