➖ Remove dependency on jwt-scala #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwojnowski
force-pushed
the
remove-jwt-scala-dependency
branch
3 times, most recently
from
3ed5d49 to
b56931a
Compare
majk-p
approved these changes
Oct 20, 2023
jwojnowski
force-pushed
the
remove-jwt-scala-dependency
branch
from
ae34728 to
6a1cb35
Compare
…supporting only RS256.
jwojnowski
force-pushed
the
remove-jwt-scala-dependency
branch
from
22568c6 to
cac285c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given a very strict and normalised use of JWTs in OIDC and an already extensive validation on the side of this library, I decided to drop usage of jwt-scala as backend for JWT verification.
This should have an impact not only at the number of dependencies, but on the performance as well, as doing all the decoding within this library enables some optimisations on decoding (in particular eliminates decoding some parts twice).