♻️ 👌 Remove Algorithm.Other #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwojnowski
force-pushed
the
remove-jwt-scala-dependency-no-other-algorithm
branch
from
646d780 to
5fb7b4f
Compare
majk-p
reviewed
Nov 3, 2023
jwojnowski
force-pushed
the
remove-jwt-scala-dependency-no-other-algorithm
branch
2 times, most recently
from
c079c2f to
89e20d7
Compare
jwojnowski
force-pushed
the
remove-jwt-scala-dependency-no-other-algorithm
branch
from
89e20d7 to
6e31bcd
Compare
majk-p
approved these changes
Nov 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses this comment.
While I like the idea of representing only supported algorithms, the error handling becomes... suboptimal, as the implementation-agnostic
JsonDecoderhas a very simple interface (Either[String, A]). This means some weird string matching is necessary.Of course, the error handling could be simplified to
CouldNotDecodeHeader, perhaps with a hint in a message it might be caused by unsupported algorithm. This would avoid most of the changes from this PR. However, I quite like an explicitUnsupportedAlgorithmerror, especially one that clearly states which algorithm has been provided.@majk-p WDYT?