Skip to content

Commit

Permalink
add more rollback tests
Browse files Browse the repository at this point in the history
  • Loading branch information
@jxsl13
jxsl13 committed Aug 9, 2024
1 parent 9ee69ee commit 36d2b81
Show file tree
Hide file tree
Showing 2 changed files with 124 additions and 14 deletions.
4 changes: 2 additions & 2 deletions Makefile
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@
.PHONY: test coverage fuzz fmt

test:
go clean -testcache && go test ./... -race -timeout 30s
go clean -testcache && go test ./... -count=1 -race -timeout 30s

coverage:
-go clean -testcache && go test ./... -timeout 30s -race -covermode=atomic -coverprofile=coverage.txt
-go clean -testcache && go test ./... -count=1 -timeout 30s -race -covermode=atomic -coverprofile=coverage.txt
rm ./coverage.txt

fuzz_prefixfs:
Expand Down
134 changes: 122 additions & 12 deletions backupfs_test.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ func TestBackupFS_Create(t *testing.T) {
basePrefix = "/base"
backupPrefix = "/backup"
)
root, base, _, backupFS := NewTestBackupFS(basePrefix, backupPrefix)
root, base, backup, backupFS := NewTestBackupFS(basePrefix, backupPrefix)
defer func() {
require.NoError(t, root.RemoveAll("/"))
}()
Expand All @@ -34,6 +34,9 @@ func TestBackupFS_Create(t *testing.T) {
)
createFile(t, base, filePath, fileContent)

baseFSState := createFSState(t, base, "/")
backupFSState := createFSState(t, backup, "/")

createFile(t, backupFS, filePath, fileContentOverwritten)

fileMustContainText(t, root, "base"+filePath, fileContentOverwritten)
Expand All @@ -52,6 +55,15 @@ func TestBackupFS_Create(t *testing.T) {
createFile(t, backupFS, newFilePath, fileContent)
fileMustContainText(t, root, "base"+newFilePath, fileContent)
mustNotExist(t, root, "backup"+newFilePath)

// ROLLBACK
err := backupFS.Rollback()
require.NoError(t, err)
// ROLLBACK

// compare initial state to state after rollback
mustEqualFSState(t, baseFSState, base, "/")
mustEqualFSState(t, backupFSState, backup, "/")
}

func TestBackupFS_Name(t *testing.T) {
Expand All @@ -70,7 +82,7 @@ func TestBackupFS_OpenFile(t *testing.T) {
basePrefix = "/base"
backupPrefix = "/backup"
)
root, base, _, backupFS := NewTestBackupFS(basePrefix, backupPrefix)
root, base, backup, backupFS := NewTestBackupFS(basePrefix, backupPrefix)

var (
filePath = "/test/01/test_01.txt"
Expand All @@ -80,6 +92,9 @@ func TestBackupFS_OpenFile(t *testing.T) {
)
openFile(t, base, filePath, fileContent, 0755)

baseFSState := createFSState(t, base, "/")
backupFSState := createFSState(t, backup, "/")

openFile(t, backupFS, filePath, fileContentOverwritten, 1755)

fileMustContainText(t, root, "base"+filePath, fileContentOverwritten)
Expand All @@ -98,6 +113,15 @@ func TestBackupFS_OpenFile(t *testing.T) {
openFile(t, backupFS, newFilePath, fileContent, 0755)
fileMustContainText(t, root, "base"+newFilePath, fileContent)
mustNotExist(t, root, "backup"+newFilePath)

// ROLLBACK
err := backupFS.Rollback()
require.NoError(t, err)
// ROLLBACK

// compare initial state to state after rollback
mustEqualFSState(t, baseFSState, base, "/")
mustEqualFSState(t, backupFSState, backup, "/")
}

func TestBackupFS_Remove(t *testing.T) {
Expand All @@ -107,7 +131,7 @@ func TestBackupFS_Remove(t *testing.T) {
basePrefix = "/base"
backupPrefix = "/backup"
)
root, base, backup, BackupFS := NewTestBackupFS(basePrefix, backupPrefix)
root, base, backup, backupFS := NewTestBackupFS(basePrefix, backupPrefix)

var (
filePath = "/test/01/test_01.txt"
Expand All @@ -116,14 +140,26 @@ func TestBackupFS_Remove(t *testing.T) {
createFile(t, base, filePath, fileContent)
fileMustContainText(t, root, "base"+filePath, fileContent)

removeFile(t, BackupFS, filePath)
mustNotExist(t, BackupFS, filePath)
baseFSState := createFSState(t, base, "/")
backupFSState := createFSState(t, backup, "/")

removeFile(t, backupFS, filePath)
mustNotExist(t, backupFS, filePath)

mustNotExist(t, base, filePath)
mustNotExist(t, root, "base"+filePath)

mustExist(t, backup, filePath)
mustExist(t, root, "backup"+filePath)

// ROLLBACK
err := backupFS.Rollback()
require.NoError(t, err)
// ROLLBACK

// compare initial state to state after rollback
mustEqualFSState(t, baseFSState, base, "/")
mustEqualFSState(t, backupFSState, backup, "/")
}

func TestBackupFS_RemoveAll(t *testing.T) {
Expand Down Expand Up @@ -158,6 +194,9 @@ func TestBackupFS_RemoveAll(t *testing.T) {
createSymlink(t, base, fileDir+"/test00.txt", symlinkDir+"/link")
createSymlink(t, base, fileDir+"/test00.txt", symlinkDir+"/link2")

baseFSState := createFSState(t, base, "/")
backupFSState := createFSState(t, backup, "/")

removeAll(t, backupFS, symlinkDir+"/link")
mustNotLExist(t, backupFS, symlinkDir+"/link")

Expand Down Expand Up @@ -187,6 +226,15 @@ func TestBackupFS_RemoveAll(t *testing.T) {

mustExist(t, backup, fileDir)
mustExist(t, backup, fileDir2)

// ROLLBACK
err := backupFS.Rollback()
require.NoError(t, err)
// ROLLBACK

// compare initial state to state after rollback
mustEqualFSState(t, baseFSState, base, "/")
mustEqualFSState(t, backupFSState, backup, "/")
}

func TestBackupFS_Rename(t *testing.T) {
Expand All @@ -197,7 +245,7 @@ func TestBackupFS_Rename(t *testing.T) {
basePrefix = "/base"
backupPrefix = "/backup"
)
root, base, backup, BackupFS := NewTestBackupFS(basePrefix, backupPrefix)
root, base, backup, backupFS := NewTestBackupFS(basePrefix, backupPrefix)

var (
oldDirName = "/test/rename"
Expand All @@ -209,27 +257,39 @@ func TestBackupFS_Rename(t *testing.T) {
require.NoError(err)
mustExist(t, root, "base"+oldDirName)

err = BackupFS.Rename(oldDirName, newDirName)
baseFSState := createFSState(t, base, "/")
backupFSState := createFSState(t, backup, "/")

err = backupFS.Rename(oldDirName, newDirName)
require.NoError(err)

mustNotExist(t, BackupFS, oldDirName)
mustExist(t, BackupFS, newDirName)
mustNotExist(t, backupFS, oldDirName)
mustExist(t, backupFS, newDirName)

mustNotExist(t, base, oldDirName)
mustExist(t, base, newDirName)

mustNotExist(t, backup, newDirName)
mustExist(t, backup, oldDirName)

err = BackupFS.Rename(newDirName, newerDirName)
err = backupFS.Rename(newDirName, newerDirName)
require.NoError(err)

mustNotExist(t, BackupFS, newDirName)
mustExist(t, BackupFS, newerDirName)
mustNotExist(t, backupFS, newDirName)
mustExist(t, backupFS, newerDirName)

mustExist(t, backup, oldDirName)
mustNotExist(t, backup, newDirName)
mustNotExist(t, backup, newerDirName)

// ROLLBACK
err = backupFS.Rollback()
require.NoError(err)
// ROLLBACK

// compare initial state to state after rollback
mustEqualFSState(t, baseFSState, base, "/")
mustEqualFSState(t, backupFSState, backup, "/")
}

func TestBackupFS_Rollback(t *testing.T) {
Expand Down Expand Up @@ -261,6 +321,9 @@ func TestBackupFS_Rollback(t *testing.T) {
createFile(t, base, fileDir2+"/test03.txt", fileContent)
createFile(t, base, fileDir2+"/test04.txt", fileContent)

baseFSState := createFSState(t, base, "/")
backupFSState := createFSState(t, backup, "/")

// delete directory & files that did exist before
removeAll(t, backupFS, fileDir)

Expand Down Expand Up @@ -322,6 +385,10 @@ func TestBackupFS_Rollback(t *testing.T) {
// but old directories that did exist before should still exist
mustExist(t, base, fileDir)
mustExist(t, backupFS, fileDir)

// compare initial state to state after rollback
mustEqualFSState(t, baseFSState, base, "/")
mustEqualFSState(t, backupFSState, backup, "/")
}

func TestBackupFS_RollbackWithForcedBackup(t *testing.T) {
Expand Down Expand Up @@ -452,6 +519,9 @@ func TestBackupFS_JSON(t *testing.T) {
createFile(t, base, fileDir2+"/test03.txt", fileContent)
createFile(t, base, fileDir2+"/test04.txt", fileContent)

baseFSState := createFSState(t, base, "/")
backupFSState := createFSState(t, backup, "/")

// delete directory & files that did exist before
removeAll(t, backupFS, fileDir)

Expand Down Expand Up @@ -541,6 +611,10 @@ func TestBackupFS_JSON(t *testing.T) {
// but old directories that did exist before should still exist
mustExist(t, base, "/test/001")
mustExist(t, backupFSNew, "/test/001")

// compare initial state to state after rollback
mustEqualFSState(t, baseFSState, base, "/")
mustEqualFSState(t, backupFSState, backup, "/")
}

func TestBackupFS_Symlink(t *testing.T) {
Expand Down Expand Up @@ -574,6 +648,9 @@ func TestBackupFS_Symlink(t *testing.T) {
createSymlink(t, base, fileDir+"/test01.txt", fileDirRoot+"/file_symlink")
createSymlink(t, base, fileDir, fileDirRoot+"/directory_symlink")

baseFSState := createFSState(t, base, "/")
backupFSState := createFSState(t, backup, "/")

// modify through BackupFS layer

// the old symlink must have been backed up after this call
Expand Down Expand Up @@ -615,6 +692,10 @@ func TestBackupFS_Symlink(t *testing.T) {
mustNotLExist(t, backup, fileDirRoot+"/file_symlink")
mustNotLExist(t, backup, fileDirRoot+"/directory_symlink")

// compare initial state to state after rollback
mustEqualFSState(t, baseFSState, base, "/")
mustEqualFSState(t, backupFSState, backup, "/")

}

func TestBackupFS_Mkdir(t *testing.T) {
Expand All @@ -639,6 +720,9 @@ func TestBackupFS_Mkdir(t *testing.T) {
err := mkdir(t, base, fileDirRoot, 0755)
require.NoError(err)

baseFSState := createFSState(t, base, "/")
backupFSState := createFSState(t, backup, "/")

err = mkdir(t, backupFS, fileDir2, 0755)
require.Error(err, "cannot create child directory without having created its parent")

Expand All @@ -652,6 +736,16 @@ func TestBackupFS_Mkdir(t *testing.T) {

// /test existed in the base filesystem and has been removed at the end -> upon removal we backup this directory.
mustLExist(t, backup, fileDirRoot)

// ROLLBACK
err = backupFS.Rollback()
require.NoError(err)
// ROLLBACK

// compare initial state to state after rollback
mustEqualFSState(t, baseFSState, base, "/")
mustEqualFSState(t, backupFSState, backup, "/")

}

func TestBackupFS_Chmod(t *testing.T) {
Expand All @@ -678,6 +772,10 @@ func TestBackupFS_Chmod(t *testing.T) {
require.NoError(err)
initialMode := initialFi.Mode()

// snapshot filesystem states
baseFSState := createFSState(t, base, "/")
backupFSState := createFSState(t, backup, "/")

// change mod
expectedNewPerm := fs.FileMode(0644)
chmod(t, backupFS, filePath, expectedNewPerm)
Expand All @@ -689,6 +787,15 @@ func TestBackupFS_Chmod(t *testing.T) {
// compare backed up permissions to initial permissions
backedUpPerm := fi.Mode()
modeMustBeEqual(t, initialMode, backedUpPerm)

// ROLLBACK
err = backupFS.Rollback()
require.NoError(err)
// ROLLBACK

// compare initial state to state after rollback
mustEqualFSState(t, baseFSState, base, "/")
mustEqualFSState(t, backupFSState, backup, "/")
}

func TestTime(t *testing.T) {
Expand Down Expand Up @@ -764,6 +871,7 @@ func TestCreateFileInSymlinkDir(t *testing.T) {
mkdirAll(t, base, originalSubDir, 0755)
createSymlink(t, base, originalLinkedDir, symlinkDir)
createFile(t, base, originalFilePath, originalFileContent)

baseFsState := createFSState(t, base, "/")
backupFsState := createFSState(t, backup, "/")

Expand Down Expand Up @@ -799,6 +907,7 @@ func TestMkdirInSymlinkDir(t *testing.T) {
mkdirAll(t, base, originalSubDir, 0755)
createSymlink(t, base, originalLinkedDir, symlinkDir)
createFile(t, base, originalFilePath, originalFileContent)

baseFsState := createFSState(t, base, "/")
backupFsState := createFSState(t, backup, "/")

Expand Down Expand Up @@ -835,6 +944,7 @@ func TestRemoveDirInSymlinkDir(t *testing.T) {
mkdirAll(t, base, originalSubDir, 0755)
createSymlink(t, base, originalLinkedDir, symlinkDir)
createFile(t, base, originalFilePath, originalFileContent)

baseFsState := createFSState(t, base, "/")
backupFsState := createFSState(t, backup, "/")

Expand Down

0 comments on commit 36d2b81

Please sign in to comment.