Implement adopted cluster e2e tests #855
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylewuolle
requested review from
Kshatrix,
eromanova,
a13x5 and
zerospiel
as code owners
kylewuolle
force-pushed
the
adopted-cluster-e2e
branch
3 times, most recently
from
58ea636 to
4d0a763
Compare
zerospiel
previously approved these changes
Jan 8, 2025
|
LGTM, the PR needs to be rebased and wait for the e2e-CI POW after the renaming to execute the tests |
Closed
kylewuolle
force-pushed
the
adopted-cluster-e2e
branch
from
fed227b to
0a94ef0
Compare
kylewuolle
force-pushed
the
adopted-cluster-e2e
branch
from
0a94ef0 to
c551da8
Compare
kylewuolle
force-pushed
the
adopted-cluster-e2e
branch
from
c551da8 to
88ed748
Compare
This was
linked to
issues
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds adopted cluster e2e tests to the suite. Also, I've ported in the various fixes around timing issues like waiting for the cluster templates to be valid and the credentials to be ready before creating deployments. Resolves #828, #339 and #871