Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] multiple services included into ClusterDeployment are deployed until first failed deployment only #875

Open
BROngineer opened this issue Jan 9, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@BROngineer
Copy link
Contributor

Describe the bug
When multiple service templates are defined in ClusterDeployment resource, they are deployed sequentially until the first failure occurs. Then charts following failed one will never be deployed.

REF issue in projectsveltos: projectsveltos/addon-controller#936

To Reproduce
Steps to reproduce the behavior:

  1. Apply ClusterDeployment with multiple services included. Add service that will fail in the middle of the list. For instance, cert-manager which will not run properly without CRDs enabled.
  2. Observe services deployed into managed cluster: only those services that come before the cert manager in the template list (including the cert manager) will be deployed
ClusterDeployment example
apiVersion: hmc.mirantis.com/v1alpha1
kind: ClusterDeployment
metadata:
  name: foo
spec:
  ...
  serviceSpec:
    services:
    - name: managed-external-secrets  # will run normally
      namespace: external-secrets
      template: external-secrets-0-11-0
    - name: managed-cert-manager  # will fail to run normally
      namespace: cert-manager
      template: cert-manager-1-16-2
    - name: managed-ingress-nginx  # will not be deployed
      namespace: ingress-nginx
      template: ingress-nginx-4-11-3
  servicesPriority: 100
  stopOnConflict: false

Expected behavior
A deployment attempt must be made against all services defined in the ClusterDeployment resource.

@BROngineer BROngineer added the bug Something isn't working label Jan 9, 2025
@github-project-automation github-project-automation bot moved this to Todo in k0rdent Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Todo
Development

No branches or pull requests

1 participant