Add IsPatch/Minor/Major/K0sUpgrade functions #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
twz123
reviewed
Jan 24, 2025
| @@ -125,6 +125,14 @@ func (v *Version) Segments() []int { | |||
| return v.segments[:v.numSegments] | |||
| } | |||
|
|
|||
| // segmentEqual checks if the segments at the specified index are equal between two versions. | |||
| func (v *Version) segmentEqual(b *Version, index int) bool { | |||
| if v == nil || b == nil || index < 0 || index >= maxSegments { | |||
There was a problem hiding this comment.
Smart-ass question: If both v and b are nil, this function returns false, albeit v == b. This somehow breaks the transitive relationship that the method's name implies (i.e. I think it's reasonable to assume that a.segmentEqual(b) is true if a == b). Should we support the receiver being nil here in the first place? The existing methods don't do it, if I'm not mistaken.
Same for the other new methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds functions for checking if upgrading to another version would be a patch, minor, major or k0s upgrade.