Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistencies within the same rule #84

Merged
merged 2 commits into from
Sep 27, 2023
Merged

Fix inconsistencies within the same rule #84

merged 2 commits into from
Sep 27, 2023

Conversation

k1LoW
Copy link
Owner

@k1LoW k1LoW commented Sep 27, 2023

@k2tzumi Thank you for your report!

@k1LoW k1LoW added the bug Something isn't working label Sep 27, 2023
@k1LoW k1LoW self-assigned this Sep 27, 2023
@github-actions
Copy link
Contributor

Code Metrics Report

main (af119e1) #84 (31e4e3b) +/-
Coverage 72.0% 72.2% +0.2%
Code to Test Ratio 1:0.1 1:0.1 -0.0
Test Execution Time 16s 21s +5s
Details
  |                     | main (af119e1) | #84 (31e4e3b) |  +/-  |
  |---------------------|----------------|---------------|-------|
+ | Coverage            |          72.0% |         72.2% | +0.2% |
  |   Files             |             21 |            21 |     0 |
  |   Lines             |           1087 |          1095 |    +8 |
+ |   Covered           |            783 |           791 |    +8 |
- | Code to Test Ratio  |          1:0.1 |         1:0.1 |  -0.0 |
  |   Code              |           3340 |          3361 |   +21 |
  |   Test              |            284 |           284 |     0 |
- | Test Execution Time |            16s |           21s |   +5s |

Code coverage of files in pull request scope (76.3% → 80.4%)

Files Coverage +/-
analyzer/decisions/recvtype/recvtype.go 80.4% +4.1%

Reported by octocov

@k1LoW k1LoW merged commit 2a8adb8 into main Sep 27, 2023
2 checks passed
@k1LoW k1LoW deleted the fix-recvtype branch September 27, 2023 12:09
@github-actions github-actions bot mentioned this pull request Sep 27, 2023
@k2tzumi
Copy link

k2tzumi commented Sep 28, 2023

We were able to resolve the issue!
Thanks for the quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants