Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support latest version #38

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Support latest version #38

merged 2 commits into from
Dec 4, 2024

Conversation

k1LoW
Copy link
Contributor

@k1LoW k1LoW commented Dec 3, 2024

Hi @k2tzumi
How about setting the default version to the latest version as the runn-action? Allow latest version to be specified.

action.yml Outdated
@@ -18,7 +18,7 @@ inputs:
version:
description: Specify runn version
required: false
default: "v0.114.1"
default: latest
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about setting the default version to the latest version as the runn-action?

The version of runn-action is linked to the version of runn
This version is updated when tagging by running the following job
If runn-action's latest version is specified, runn's latest version is expected to be used if the version is published in conjunction with runn-action.
https://github.com/k2tzumi/runn-action/blob/main/.github/workflows/release.yml

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood 👍

On the other hand, it seems a waste not to be able to specify latest.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, it looks like you should update the v0 and latest tags.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see
I guess I'll add a process to re-cut the v0 and latest tags in the workflow at the time of release.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR only allows to specify the latest version.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue registered
#42
#43

@k1LoW k1LoW changed the title Support latest version and set default to latest Support latest version Dec 3, 2024
@k2tzumi k2tzumi merged commit dc70493 into k2tzumi:main Dec 4, 2024
1 check passed
@k1LoW k1LoW deleted the default-latest branch December 4, 2024 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants