Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit action before directive be removed from DOM #1419

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

k3nsei
Copy link
Owner

@k3nsei k3nsei commented Nov 14, 2023

feat: emit action before directive destroy

chore: extend peer deps to include angular v17

Refs: #1418
Release-As: 16.1.0

Copy link

vercel bot commented Nov 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ng-in-viewport ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2023 4:35pm

Copy link

@tinesoft tinesoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comments added
Overall LGTM!

chore: extend peer deps to include angular v17

Refs: #1418
Release-As: 16.1.0
@k3nsei k3nsei force-pushed the feature/emit-action-on-destroy branch from d75d2d0 to 927c5ba Compare November 14, 2023 16:34
@k3nsei k3nsei merged commit ec25af9 into develop Nov 14, 2023
4 of 5 checks passed
@k3nsei k3nsei deleted the feature/emit-action-on-destroy branch November 14, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants