Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose --disable-cloud-provider feature and cloud-provider= kubelet arg #106

Closed
anmazzotti opened this issue May 8, 2024 · 0 comments · Fixed by #112
Closed

Expose --disable-cloud-provider feature and cloud-provider= kubelet arg #106

anmazzotti opened this issue May 8, 2024 · 0 comments · Fixed by #112

Comments

@anmazzotti
Copy link
Contributor

The current implementation of DisableExternalCloudProvider is a bit confusing (sorry for that).

As discussed in this comment, it would be more explicit to have two dedicated fields in the server config:

  1. disableCloudProvider to add the --disable-cloud-provider feature flag on k3s.
  2. cloudProviderName to set an explicit cloud provider name.

The DisableExternalCloudProvider flag should be deprecated in the upcoming v1beta2 version.

An equivalent config would then be:

serverConfig:
   disableCloudProvider: true
   cloudProviderName: external
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant