Deprecate DisableExternalCloudProvider #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mogliang
reviewed
May 14, 2024
anmazzotti
force-pushed
the
allow_disable_cloud_controller_and_set_cloud_provider_arg
branch
from
599abba
to
e05413a
Compare
Signed-off-by: Andrea Mazzotti <andrea.mazzotti@suse.com>
anmazzotti
force-pushed
the
allow_disable_cloud_controller_and_set_cloud_provider_arg
branch
from
e05413a
to
ca169fc
Compare
mogliang
reviewed
May 15, 2024
mogliang
reviewed
May 15, 2024
mogliang
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies for the
cabp3v1import. I think I accidentally added that in a previous PR, so I took the occasion to clean that up.This PR Closes #106