Skip to content

Commit

Permalink
Add supervisor cert/key to rotate list
Browse files Browse the repository at this point in the history
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
  • Loading branch information
brandond committed Apr 5, 2024
1 parent 9846a72 commit 60248c4
Show file tree
Hide file tree
Showing 4 changed files with 18 additions and 4 deletions.
2 changes: 1 addition & 1 deletion pkg/cli/cmds/certs.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ var (
DataDirFlag,
&cli.StringSliceFlag{
Name: "service,s",
Usage: "List of services to manage certificates for. Options include (admin, api-server, controller-manager, scheduler, " + version.Program + "-controller, " + version.Program + "-server, cloud-controller, etcd, auth-proxy, kubelet, kube-proxy)",
Usage: "List of services to manage certificates for. Options include (admin, api-server, controller-manager, scheduler, supervisor, " + version.Program + "-controller, " + version.Program + "-server, cloud-controller, etcd, auth-proxy, kubelet, kube-proxy)",
Value: &ServicesList,
},
}
Expand Down
11 changes: 9 additions & 2 deletions pkg/util/services/services.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ const (
APIServer = "api-server"
Admin = "admin"
AuthProxy = "auth-proxy"
CertificateAuthority = "certificate-authority"
CloudController = "cloud-controller"
ControllerManager = "controller-manager"
ETCD = "etcd"
Expand All @@ -20,7 +21,7 @@ const (
ProgramController = "-controller"
ProgramServer = "-server"
Scheduler = "scheduler"
CertificateAuthority = "certificate-authority"
Supervisor = "supervisor"
)

var Agent = []string{
Expand All @@ -30,13 +31,14 @@ var Agent = []string{
}

var Server = []string{
Admin,
APIServer,
Admin,
AuthProxy,
CloudController,
ControllerManager,
ETCD,
Scheduler,
Supervisor,
version.Program + ProgramServer,
}

Expand Down Expand Up @@ -96,6 +98,11 @@ func FilesForServices(controlConfig config.Control, services []string) (map[stri
filepath.Join(agentDataDir, "client-"+version.Program+"-controller.crt"),
filepath.Join(agentDataDir, "client-"+version.Program+"-controller.key"),
}
case Supervisor:
fileMap[service] = []string{
controlConfig.Runtime.ClientSupervisorCert,
controlConfig.Runtime.ClientSupervisorKey,
}
case AuthProxy:
fileMap[service] = []string{
controlConfig.Runtime.ClientAuthProxyCert,
Expand Down
8 changes: 8 additions & 0 deletions pkg/util/services/services_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,10 @@ func Test_UnitFilesForServices(t *testing.T) {
"/var/lib/rancher/k3s/server/tls/client-scheduler.crt",
"/var/lib/rancher/k3s/server/tls/client-scheduler.key",
},
"supervisor": []string{
"/var/lib/rancher/k3s/server/tls/client-supervisor.crt",
"/var/lib/rancher/k3s/server/tls/client-supervisor.key",
},
},
},
{
Expand Down Expand Up @@ -138,6 +142,10 @@ func Test_UnitFilesForServices(t *testing.T) {
"/var/lib/rancher/k3s/server/tls/client-scheduler.crt",
"/var/lib/rancher/k3s/server/tls/client-scheduler.key",
},
"supervisor": []string{
"/var/lib/rancher/k3s/server/tls/client-supervisor.crt",
"/var/lib/rancher/k3s/server/tls/client-supervisor.key",
},
},
},
{
Expand Down
1 change: 0 additions & 1 deletion tests/e2e/validatecluster/validatecluster_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,6 @@ var _ = Describe("Verify Create", Ordered, func() {
// Everything else should be changed.
var expectResult = []string{
"client-ca.crt", "client-ca.key", "client-ca.nochain.crt",
"client-supervisor.crt", "client-supervisor.key",
"peer-ca.crt", "peer-ca.key",
"server-ca.crt", "server-ca.key",
"request-header-ca.crt", "request-header-ca.key",
Expand Down

0 comments on commit 60248c4

Please sign in to comment.