Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to newer OS images for install testing #10681

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

dereknola
Copy link
Contributor

@dereknola dereknola commented Aug 6, 2024

Proposed Changes

Update the OS boxes used for install and E2E testing.

  • Moved off generic publisher, as they suddenly stopped publishing boxes 7 months ago. The new box choices are stable, regularly updated images from known 3rd parties.
  • Replaced centos7, which is EOL and the repo lists are now dead, with centos stream 9. While there has been a move away from centOS stream, it is still used enough for testing purposes. generic/centos-7 ➡️ eurolinux-vagrant/centos-stream-9
  • Simplified E2E OS setup code to handle more generic versions of OSes

Types of Changes

Testing Changes

Verification

CI still green

Testing

Its all testing

Linked Issues

N/A

User-Facing Change


Further Comments

While I could have chosen more first party publishers, like the official rocky linux boxes, these are not actually updated regularly (rocky 8 is still on 8.9 despite 8.10 being published in May)

Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
@dereknola dereknola marked this pull request as ready for review August 7, 2024 18:35
@dereknola dereknola requested a review from a team as a code owner August 7, 2024 18:35
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.49%. Comparing base (3aceb85) to head (6a62db8).
Report is 5 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (3aceb85) and HEAD (6a62db8). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (3aceb85) HEAD (6a62db8)
e2etests 7 6
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10681      +/-   ##
==========================================
- Coverage   49.46%   43.49%   -5.97%     
==========================================
  Files         179      179              
  Lines       14955    14955              
==========================================
- Hits         7397     6505     -892     
- Misses       6192     7256    +1064     
+ Partials     1366     1194     -172     
Flag Coverage Δ
e2etests 36.27% <ø> (-9.88%) ⬇️
inttests 36.70% <ø> (-0.02%) ⬇️
unittests 13.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dereknola dereknola merged commit ac247d2 into k3s-io:master Aug 12, 2024
36 checks passed
@dereknola dereknola deleted the install_os_overhaul branch August 12, 2024 16:45
dereknola added a commit to dereknola/k3s that referenced this pull request Sep 3, 2024
* Update to newer OS images for install testing
* Update vagrant images used for E2E

Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola added a commit to dereknola/k3s that referenced this pull request Sep 3, 2024
* Update to newer OS images for install testing
* Update vagrant images used for E2E

Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola added a commit to dereknola/k3s that referenced this pull request Sep 3, 2024
* Update to newer OS images for install testing
* Update vagrant images used for E2E

Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola added a commit that referenced this pull request Sep 4, 2024
* Update to newer OS images for install testing
* Update vagrant images used for E2E

Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola added a commit that referenced this pull request Sep 4, 2024
* Update to newer OS images for install testing
* Update vagrant images used for E2E

Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola added a commit to dereknola/k3s that referenced this pull request Sep 6, 2024
* Update to newer OS images for install testing
* Update vagrant images used for E2E

Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola added a commit that referenced this pull request Sep 6, 2024
* Update to newer OS images for install testing
* Update vagrant images used for E2E

Signed-off-by: Derek Nola <derek.nola@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants