Skip to content
This repository has been archived by the owner on Aug 22, 2022. It is now read-only.

[samba] Unmaintained image with security flaws #1401

Closed
runningman84 opened this issue Feb 5, 2022 · 5 comments · Fixed by #1402
Closed

[samba] Unmaintained image with security flaws #1401

runningman84 opened this issue Feb 5, 2022 · 5 comments · Fixed by #1402

Comments

@runningman84
Copy link
Contributor

Details

Helm chart name and version:
samba

Container name and tag:
dperson/samba

The docker image suffers from security issues like dperson/samba#407.

I have't found a better docker image yet, this looks promising but there are k8s issues:
https://github.com/crazy-max/docker-samba

I think a special docker image and a configmap for the smb.conf and secrets for the users might be a better longterm solution.

@bjw-s
Copy link
Contributor

bjw-s commented Feb 5, 2022

I'd be fine with switching it out for a more maintained image.

Could you be more specific about the k8s issues with the alternative you provided?
It seems that it can be configured with ENV vars and a yaml file (can be provided by either configMap or Secret). That would make it work pretty well I'd think?

@bjw-s bjw-s changed the title Samba helm chart uses unmaintained image with security flaws [samba] Unmaintained image with security flaws Feb 5, 2022
@runningman84
Copy link
Contributor Author

I have seen this issue but I haven't double checked it:
crazy-max/docker-samba#12

@bjw-s
Copy link
Contributor

bjw-s commented Feb 5, 2022

This person has mounted a configMap to the /data folder. But configMaps are always read-only. If the configuration has to be mounted to a path inside /data, ideally a subPath should have been used.

@runningman84
Copy link
Contributor Author

/data should be emptydir and the configfile a subpath

@bjw-s
Copy link
Contributor

bjw-s commented Feb 5, 2022

Sounds about right 👍🏻

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants