Skip to content
This repository has been archived by the owner on Aug 22, 2022. It is now read-only.

[samba] changed samba server docker image #1402

Merged
merged 7 commits into from
Feb 5, 2022
Merged

[samba] changed samba server docker image #1402

merged 7 commits into from
Feb 5, 2022

Conversation

runningman84
Copy link
Contributor

@runningman84 runningman84 commented Feb 5, 2022 •
edited
Loading

Description of the change

Use another docker image which has support for configmaps and has fixed the latest security issues.

Benefits

Better docker image.

Possible drawbacks

This might be a breaking change for current users.

Applicable issues

Additional information

Checklist

  • Title of the PR starts with chart name (e.g. [home-assistant])
  • Chart version bumped in Chart.yaml according to semver.
  • Chart artifacthub.io/changes changelog annotation has been updated in Chart.yaml. See Artifact Hub documentation for more info.
  • Variables have been documented in the values.yaml file.

@runningman84 runningman84 changed the title [sambba] changed samba server docker image [samba] changed samba server docker image Feb 5, 2022
@ghost ghost added size/M Categorises a PR that changes 30-99 lines, ignoring generated files. precommit:failed CI status: pre-commit validation failed labels Feb 5, 2022
@ghost ghost added precommit:ok CI status: pre-commit validation successful changelog:failed CI status: changelog validation failed and removed precommit:failed CI status: pre-commit validation failed labels Feb 5, 2022
@runningman84 runningman84 mentioned this pull request Feb 5, 2022
Closed
@ghost ghost added changelog:ok CI status: changelog validation successful lint:failed CI status: linting failed and removed changelog:failed CI status: changelog validation failed labels Feb 5, 2022
@ghost ghost added lint:ok CI status: linting successful install:ok CI status: install successful and removed lint:failed CI status: linting failed labels Feb 5, 2022
bjw-s
bjw-s approved these changes Feb 5, 2022
View reviewed changes
Copy link
Contributor

@bjw-s bjw-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this PR @runningman84!! LGTM 👍

@bjw-s bjw-s merged commit f7b54c6 into k8s-at-home:master Feb 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bjw-s bjw-s bjw-s approved these changes

@billimek billimek Awaiting requested review from billimek billimek is a code owner

@carpenike carpenike Awaiting requested review from carpenike carpenike is a code owner

@onedr0p onedr0p Awaiting requested review from onedr0p onedr0p is a code owner

Assignees
No one assigned
Labels
changelog:ok CI status: changelog validation successful install:ok CI status: install successful lint:ok CI status: linting successful precommit:ok CI status: pre-commit validation successful size/M Categorises a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[samba] Unmaintained image with security flaws
2 participants
@runningman84 @bjw-s