Skip to content
This repository has been archived by the owner on Aug 22, 2022. It is now read-only.

[common] Treat custom service ports as enabled by default #124

Open
MurzNN opened this issue Feb 8, 2022 · 0 comments
Open

[common] Treat custom service ports as enabled by default #124

MurzNN opened this issue Feb 8, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@MurzNN
Copy link
Contributor

MurzNN commented Feb 8, 2022

Details

When I fill this structure for service:

service:
  main:
    ports:
      appservice:
        port: 9993
      webhook:
        port: 9000
      metrics:
        port: 9002

as result common library renders only single empty port in Service, instead of list of all described ports:

spec:
  type: ClusterIP
  ports:
  - port: 
    targetPort: http
    protocol: TCP
    name: http

And to make desired port configuration I need to explicitly disable default http port and enable all others, like this:

service:
  main:
    ports:
      http:
        enabled: false
      appservice:
        enabled: true
        port: 9993
      webhook:
        enabled: true
        port: 9000
      metrics:
        enabled: true
        port: 9002

Helm chart name: common

Describe the solution you'd like: I suggest to treat custom service ports as enabled by default, to not write "enabled = true" on each new port, and disable default http port if no value is specified.

@MurzNN MurzNN added the enhancement New feature or request label Feb 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant