This repository has been archived by the owner on Aug 22, 2022. It is now read-only.
[common] Add support for setting hostPort on pods
#120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Utku Ozdemir <uoz@protonmail.com>
utkuozdemir
requested review from
billimek,
bjw-s,
carpenike and
onedr0p
as code owners
|
After discussing with @utkuozdemir in discord, we need to think this over, since hostPort is on a container level not pod. It might better to just patch the resource with kustomize using Flux's |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Utku Ozdemir uoz@protonmail.com
Description of the change
Benefits
Possibility to specify hostPort
Possible drawbacks
none
Applicable issues
Simple alternative to MetalLB/proxies
hostPortsupport to the common chart #116Additional information
As discussed in Discord
Tested on the
common-testchart inside the repo, working as expectedChecklist
Chart.yamlaccording to semver.