Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error parsing the pci address #772

Closed
ianb-mp opened this issue Sep 6, 2024 · 2 comments
Closed

error parsing the pci address #772

ianb-mp opened this issue Sep 6, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@ianb-mp
Copy link
Contributor

ianb-mp commented Sep 6, 2024

I'm seeing error error parsing the pci address "10001:80:05.0" in sriov-network-config-daemon log output.

This is due to a bug in jaypipes/ghw which is fixed in latest release - see: jaypipes/ghw#373

I would send a PR to bump the version, however encountered errors when running make all after the change:

pkg/host/internal/lib/ghw/ghw.go:1: : # github.com/k8snetworkplumbingwg/sriov-network-operator/pkg/host/internal/lib/ghw
pkg/host/internal/lib/ghw/ghw.go:28:9: cannot use ghw.PCI() (value of type *pci.Info) as Info value in return statement: *pci.Info does not implement Info (missing method ListDevices) (typecheck)
package ghw
pkg/host/manager.go:9:2: could not import github.com/k8snetworkplumbingwg/sriov-network-operator/pkg/host/internal/lib/ghw (-: # github.com/k8snetworkplumbingwg/sriov-network-operator/pkg/host/internal/lib/ghw
pkg/host/internal/lib/ghw/ghw.go:28:9: cannot use ghw.PCI() (value of type *pci.Info) as Info value in return statement: *pci.Info does not implement Info (missing method ListDevices)) (typecheck)
        "github.com/k8snetworkplumbingwg/sriov-network-operator/pkg/host/internal/lib/ghw"

I believe the issue is due to deprecated ListDevices() method in latest ghw version -see: jaypipes/ghw#348 . I'm not sure how to resolve that as I'm not familiar with the mock library being used.

fyi @ykulazhenkov

@adrianchiris
Copy link
Collaborator

we should version bump this lib here and in sriov-network-device-plugin.

@ianb-mp
Copy link
Contributor Author

ianb-mp commented Nov 12, 2024

Fixed by #796

@ianb-mp ianb-mp closed this as completed Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants