Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ConnectX-8 to supported NICs list #778

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Add ConnectX-8 to supported NICs list #778

merged 1 commit into from
Oct 29, 2024

Conversation

e0ne
Copy link
Collaborator

@e0ne e0ne commented Sep 19, 2024

No description provided.

@github-actions GitHub Actions
Copy link

Thanks for your PR,
To run vendors CIs, Maintainers can use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs, Maintainers can use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@coveralls
Copy link

coveralls commented Sep 19, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11290693719

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 45.017%
Totals Coverage Status
Change from base Build 11258053806: 0.03%
Covered Lines: 6663
Relevant Lines: 14801
💛 - Coveralls

SchSeba
SchSeba reviewed Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@SchSeba SchSeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @e0ne can you also add it to the hw supported table?

@e0ne
Copy link
Collaborator Author

e0ne commented Sep 20, 2024

Hi @e0ne can you also add it to the hw supported table?

done

@e0ne e0ne closed this Sep 24, 2024
@e0ne e0ne reopened this Sep 24, 2024
@github-actions GitHub Actions
Copy link

Thanks for your PR,
To run vendors CIs, Maintainers can use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs, Maintainers can use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@e0ne e0ne requested a review from SchSeba October 8, 2024 07:10
adrianchiris
adrianchiris approved these changes Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@adrianchiris adrianchiris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SchSeba
SchSeba reviewed Oct 10, 2024
View reviewed changes
doc/supported-hardware.md Outdated
@@ -22,6 +22,7 @@ The following SR-IOV capable hardware is supported with sriov-network-operator:
| Mellanox MT28908 Family [ConnectX-6 Dx] | 15b3 | 101d |
| Mellanox MT28908 Family [ConnectX-6 Lx] | 15b3 | 101f |
| Mellanox MT2910 Family [ConnectX-7 | 15b3 | 1021 |
| Mellanox CX8 Family [ConnectX-8 | 15b3 | 1023 |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please update the table below with the card's supported capabilities?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@e0ne e0ne requested a review from SchSeba October 10, 2024 11:12
wizhaoredhat
wizhaoredhat reviewed Oct 10, 2024
View reviewed changes
doc/supported-hardware.md Outdated
@@ -22,6 +22,7 @@ The following SR-IOV capable hardware is supported with sriov-network-operator:
| Mellanox MT28908 Family [ConnectX-6 Dx] | 15b3 | 101d |
| Mellanox MT28908 Family [ConnectX-6 Lx] | 15b3 | 101f |
| Mellanox MT2910 Family [ConnectX-7 | 15b3 | 1021 |
| Mellanox CX8 Family [ConnectX-8 | 15b3 | 1023 |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: Typo , missing end square "]" bracket.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually for the CX-7 as well.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@e0ne
Add NVIDIA ConnectX-8 to supported NICs list
6556c92 
Signed-off-by: Ivan Kolodiazhnyi <ikolodiazhny@nvidia.com>
@SchSeba SchSeba merged commit eb96108 into k8snetworkplumbingwg:master Oct 29, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wizhaoredhat wizhaoredhat wizhaoredhat left review comments

@ykulazhenkov ykulazhenkov ykulazhenkov approved these changes

@adrianchiris adrianchiris adrianchiris approved these changes

@SchSeba SchSeba SchSeba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@e0ne @coveralls @SchSeba @adrianchiris @ykulazhenkov @wizhaoredhat