-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: GetDevlinkDeviceParam to handle edge-cases correctly #782
Merged
e0ne
merged 1 commit into
k8snetworkplumbingwg:master
from
ykulazhenkov:pr-fix-getdevlinkdeviceparam
Oct 2, 2024
Merged
Fix: GetDevlinkDeviceParam to handle edge-cases correctly #782
e0ne
merged 1 commit into
k8snetworkplumbingwg:master
from
ykulazhenkov:pr-fix-getdevlinkdeviceparam
Oct 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for your PR,
To skip the vendors CIs, Maintainers can use one of:
|
ykulazhenkov
force-pushed
the
pr-fix-getdevlinkdeviceparam
branch
from
September 23, 2024 16:47
dba3c60
to
254dd8f
Compare
On some kernels GetDevlinkDeviceParam may return empty values for some kernel parameters. The netlink library is able to handle this, but the code in GetDevlinkDeviceParam function may panic if unexpected value received. Add extra checks to avoid panics
ykulazhenkov
force-pushed
the
pr-fix-getdevlinkdeviceparam
branch
from
September 23, 2024 16:49
254dd8f
to
61aacb5
Compare
Pull Request Test Coverage Report for Build 10998783450Details
💛 - Coveralls |
adrianchiris
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
e0ne
approved these changes
Oct 1, 2024
zeeke
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some kernels
GetDevlinkDeviceParam
may return empty values for some kernel parameters. The netlink library is able to handle this, but the code inGetDevlinkDeviceParam
function may panic if unexpected value received.Add extra checks to avoid panics.
The problem was discovered on an old kernel (5.15.0-25-generic) for Ubuntu 22.04.
The parameter has no value:
segfault happens when trying to set the value
In the recent kernels everything works as expected. This change is primarily intended to enhance the operator's robustness, rather than to address any current issues.