Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump dependencies: K8S, controller-runtime and Go #495

Merged
merged 4 commits into from
Sep 4, 2023
Merged

Bump dependencies: K8S, controller-runtime and Go #495

merged 4 commits into from
Sep 4, 2023

Conversation

liornoy
Copy link
Contributor

@liornoy liornoy commented Aug 29, 2023

In this PR we bump different core dependencies to be more updated with current releases
and avoid incompatibilities. The dependencies we bump here are:
K8S to 1.27
controller-runtime to v0.15
Go to v1.20

@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@coveralls
Copy link

coveralls commented Aug 29, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6011025912

  • 2 of 6 (33.33%) changed or added relevant lines in 3 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.7%) to 25.378%
Changes Missing Coverage Covered Lines Changed/Added Lines %
controllers/sriovnetworknodepolicy_controller.go 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
controllers/sriovibnetwork_controller.go 2 66.04%
Totals Coverage Status
Change from base Build 5949253686: 0.7%
Covered Lines: 2117
Relevant Lines: 8342
💛 - Coveralls

@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@liornoy
Bump dependencies: Go, K8S, and controller-runtime
6794c32 
This commit bumps Go to v1.20, K8S to v0.27.4 and the
controller-runtime to v0.15.2

Updated go.mod, go.sum and the vendor dir.

Also bumps golangci-lint version to latest to support
Go v1.20

Signed-off-by: Lior Noy <lnoy@redhat.com>
@liornoy
Fix the breaking changes in the controllers
25fca14 
This commit fixes the breaking changes from the version bump.

Signed-off-by: Lior Noy <lnoy@redhat.com>
@liornoy
Update go version in workflows and Dockerfiles
6ef4579 
This commit updates go to v1.20 in the workflows and Dockerfiles.

Signed-off-by: Lior Noy <lnoy@redhat.com>
@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@liornoy
Copy link
Contributor Author

liornoy commented Aug 29, 2023

Some errors were raised by the golangci-lint. I will handle them soon. Meanwhile reviews are more than welcomed.

@liornoy
Fix the golangci to support Go v1.20
ec33770 
Bump the golangci-lint version to support Go v1.20
and remove deprecated linters.

Signed-off-by: Lior Noy <lnoy@redhat.com>
@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

SchSeba
SchSeba reviewed Aug 29, 2023
View reviewed changes
.golangci.yml Show resolved Hide resolved
SchSeba
SchSeba approved these changes Aug 30, 2023
View reviewed changes
Copy link
Collaborator

@SchSeba SchSeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thanks!

@e0ne e0ne merged commit 73e7564 into k8snetworkplumbingwg:master Sep 4, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SchSeba SchSeba SchSeba approved these changes

@e0ne e0ne e0ne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@liornoy @coveralls @e0ne @SchSeba