Let "depoly-setup.sh" and "undeploy.sh" fail on error #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR,
To skip the vendors CIs use one of:
|
Pull Request Test Coverage Report for Build 8755557051Details
💛 - Coveralls |
|
Hi @thom311 can you please do a force push I am not able to trigger the k8s lane for some reason |
Ignoring errors seems not best. It can make it harder to find problems with the script. If a command in the script is known to fail for valid reasons, then that should be treated specially (for example, with `|| :`). By default, treat any unexpected failure as fatal and propagate the failure to the caller. Fixes: 8844150 ('Add RBAC for cluster resource')
thom311
force-pushed
the
th/script-exit-on-error
branch
from
fea72a9
to
624a16f
Compare
|
/test-all |
Pull Request Test Coverage Report for Build 10455381530Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
all green merging nice work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignoring errors seems not best. It can make it harder to find problems with the script.
If a command in the script is known to fail for valid reasons, then that should be treated specially (for example, with
|| :). By default, treat any unexpected failure as fatal and propagate the failure to the caller.Fixes: 8844150 ('Add RBAC for cluster resource')
CC: @pliurh