Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve user defined annotations on SriovNetworks #775

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Preserve user defined annotations on SriovNetworks #775

merged 1 commit into from
Sep 18, 2024

Conversation

zeeke
Copy link
Member

@zeeke zeeke commented Sep 12, 2024

If an SriovNetwork is created with some annotations, the operator deletes them during the creation of the related NetworkAttachmentDefinition.

Make the reconcilers append the last-network-namespace annotation without deleting existing ones.

The same concept applies for SriovIbNetworks and OVSNetworks

@github-actions GitHub Actions
Copy link

Thanks for your PR,
To run vendors CIs, Maintainers can use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs, Maintainers can use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@coveralls
Copy link

coveralls commented Sep 12, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10830668086

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.04%) to 44.977%
Files with Coverage Reduction New Missed Lines %
controllers/drain_controller.go 1 68.06%
controllers/generic_network_controller.go 5 74.38%
Totals Coverage Status
Change from base Build 10734670028: -0.04%
Covered Lines: 6599
Relevant Lines: 14672
💛 - Coveralls

@zeeke
Preserve user defined annotations on SriovNetworks
4d9ec9c 
If an SriovNetwork is created with some annotations, the operator
deletes them during the creation of  the related NetworkAttachmentDefinition.

Make the reconcilers append the `last-network-namespace` annotation
without deleting existing ones.

The same concept applies for `SriovIbNetworks` and `OVSNetworks`

Signed-off-by: Andrea Panattoni <apanatto@redhat.com>
adrianchiris
adrianchiris approved these changes Sep 17, 2024
View reviewed changes
Copy link
Collaborator

@adrianchiris adrianchiris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

SchSeba
SchSeba approved these changes Sep 18, 2024
View reviewed changes
Copy link
Collaborator

@SchSeba SchSeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SchSeba SchSeba merged commit 8526311 into k8snetworkplumbingwg:master Sep 18, 2024
12 of 13 checks passed
@zeeke zeeke mentioned this pull request Sep 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianchiris adrianchiris adrianchiris approved these changes

@SchSeba SchSeba SchSeba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zeeke @coveralls @SchSeba @adrianchiris