Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The PullSecretRef for medusa is ignored in the standalone deployment of medusa #1240

Closed
tuxBurner opened this issue Mar 12, 2024 · 0 comments · Fixed by #1241
Closed

The PullSecretRef for medusa is ignored in the standalone deployment of medusa #1240

tuxBurner opened this issue Mar 12, 2024 · 0 comments · Fixed by #1241
Labels
bug Something isn't working done Issues in the state 'done'

Comments

@tuxBurner
Copy link
Contributor

What happened?

The PullSecretRef for medusa is not set for the standalone medusa deployment. This leads that the helm operation fails, when the image comes from an internal docker registry.

I looked into the code and the configuration for the pullSecretRef is completely ignored for the medusa standalone deployment.

https://github.com/k8ssandra/k8ssandra-operator/blob/main/pkg/medusa/reconcile.go#L529

Did you expect to see something different?

That the configured pullSecretRef is set as ImagePullSecrets at the deployment.

How to reproduce it (as minimally and precisely as possible):

Environment

  • K8ssandra Operator version:

    v1.13.0
@tuxBurner tuxBurner added the bug Something isn't working label Mar 12, 2024
tuxBurner added a commit to micromata/k8ssandra-operator that referenced this issue Mar 12, 2024
@tuxBurner
k8ssandra#1240 set the PullSecretRef configured for medusa as imagePu…
7385c2c 
…llSecrets at the standalone deployment
tuxBurner added a commit to micromata/k8ssandra-operator that referenced this issue Mar 12, 2024
@tuxBurner
k8ssandra#1240 added fix to Changelog.md
321decd
@tuxBurner tuxBurner mentioned this issue Mar 12, 2024
Merged
5 tasks
tuxBurner added a commit to micromata/k8ssandra-operator that referenced this issue Mar 12, 2024
@tuxBurner
k8ssandra#1240 make the linter happy
5b107f3
tuxBurner added a commit to micromata/k8ssandra-operator that referenced this issue Mar 12, 2024
@tuxBurner
k8ssandra#1240 Fixes applying defaults
0380f7e
adejanovski pushed a commit that referenced this issue Apr 15, 2024
@tuxBurner
Feature/#1240 medusa pull secret ref (#1241)
9577b31
@adejanovski adejanovski added the done Issues in the state 'done' label Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working done Issues in the state 'done'
Projects
No open projects
K8ssandra
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/#1240 medusa pull secret ref micromata/k8ssandra-operator
2 participants
@tuxBurner @adejanovski