Upgrade cass-operator version and enable using 5.x.x and 7.x.x versions #1007
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## main #1007 +/- ##
==========================================
+ Coverage 57.42% 57.47% +0.04%
==========================================
Files 99 99
Lines 10013 10010 -3
==========================================
+ Hits 5750 5753 +3
+ Misses 3769 3765 -4
+ Partials 494 492 -2
|
| claims: | ||
| description: "Claims lists the names of resources, defined in | ||
| spec.resourceClaims, that are used by this container. \n This | ||
| is an alpha field and requires enabling the DynamicResourceAllocation | ||
| feature gate. \n This field is immutable. It can only be set | ||
| for containers." | ||
| items: | ||
| description: ResourceClaim references one entry in PodSpec.ResourceClaims. | ||
| properties: | ||
| name: | ||
| description: Name must match the name of one entry in pod.spec.resourceClaims | ||
| of the Pod where this field is used. It makes that resource | ||
| available inside a container. | ||
| type: string | ||
| required: | ||
| - name | ||
| type: object | ||
| type: array | ||
| x-kubernetes-list-map-keys: | ||
| - name | ||
| x-kubernetes-list-type: map |
There was a problem hiding this comment.
question: Are these changes related? Or are these due to an upgraded version?
There was a problem hiding this comment.
I think it's related to the kubernetes dependency upgrades (from 0.25 to 0.26) that were required by the cass-operator upgrade.
There was a problem hiding this comment.
yup, that's here: https://kubernetes.io/blog/2022/12/15/dynamic-resource-allocation/
|
|
||
| t.Run("affinity on zone label", func(t *testing.T) { | ||
| //goland:noinspection GoDeprecation | ||
| actual := computeNodeAffinityLabels(&cassdcapi.CassandraDatacenter{ | ||
| Spec: cassdcapi.CassandraDatacenterSpec{ | ||
| Racks: []cassdcapi.Rack{{ | ||
| Name: "rack1", | ||
| Zone: "zone1", | ||
| }}, | ||
| }}, "rack1") | ||
| require.NotNil(t, actual) | ||
| assert.Equal(t, "zone1", actual[zoneLabel]) | ||
| }) |
There was a problem hiding this comment.
question: Do we not need to test affinity labels anymore?
There was a problem hiding this comment.
affinity labels are still tested, and NodeAffinityLabels have now superceded the Zone field that was previously used for this, and has now been fully removed.
What this PR does:
Upgrades cass-operator to the sha that supports new version numbers, and adds support for these version numbers in k8ssandra-operator as well.
Which issue(s) this PR fixes:
Fixes #1005
Checklist