Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/#1240 medusa pull secret ref #1241

Merged
merged 6 commits into from
Apr 15, 2024
Merged

Feature/#1240 medusa pull secret ref #1241

merged 6 commits into from
Apr 15, 2024

Conversation

tuxBurner
Copy link
Contributor

What this PR does:

Which issue(s) this PR fixes:
Fixes #1240

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated not needed IMHO because it fixes something what is already documentated
  • CHANGELOG.md updated (not required for documentation PRs)
  • CLA Signed: DataStax CLA

@tuxBurner tuxBurner requested a review from a team as a code owner March 12, 2024 14:18
@codecov Codecov
Copy link

codecov bot commented Mar 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.87%. Comparing base (1864ddb) to head (0380f7e).
Report is 1 commits behind head on main.

❗ Current head 0380f7e differs from pull request most recent head dfa6096. Consider uploading reports for the commit dfa6096 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1241      +/-   ##
==========================================
+ Coverage   57.43%   57.87%   +0.43%     
==========================================
  Files         103      103              
  Lines       10808    10791      -17     
==========================================
+ Hits         6208     6245      +37     
+ Misses       4063     4011      -52     
+ Partials      537      535       -2
Files Coverage Δ
controllers/k8ssandra/medusa_reconciler.go 66.04% <100.00%> (ø)
pkg/medusa/reconcile.go 69.90% <100.00%> (+8.95%) ⬆️

... and 8 files with indirect coverage changes

@tuxBurner
Copy link
Contributor Author

Anyone liking to review this PR ? ❤️

adejanovski
adejanovski approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@adejanovski adejanovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for fixing this 👍

@adejanovski
Copy link
Contributor

Hi @tuxBurner, your branches has some conflicts and can't make it into the release we're cutting out today.
Once the release is done, please fix those conflicts after rebasing and we'll issue a patch release with it.
Thanks!

@tuxBurner
Copy link
Contributor Author

@adejanovski okay merge conflict is fixxed

@tuxBurner
Copy link
Contributor Author

@adejanovski well now suddenly i get a failure on the Quality Gate check. But the Code was fine before 👍 Am i supposed to fix this or can I ignore it ?

@adejanovski
Copy link
Contributor

@adejanovski well now suddenly i get a failure on the Quality Gate check. But the Code was fine before 👍 Am i supposed to fix this or can I ignore it ?

You can ignore it, no worries

adejanovski
adejanovski requested changes Apr 10, 2024
View reviewed changes
CHANGELOG/CHANGELOG-1.14.md Outdated
@@ -23,3 +24,4 @@ When cutting a new release, update the `unreleased` heading to the tag being gen
* [CHANGE] Update Medusa to v0.20.1
* [BUGFIX] [#1235](https://github.com/k8ssandra/k8ssandra-operator/issues/1235) Prevent operator from modifying the spec when superUserRef is not set. Also, remove the injection to mount secrets to cassandra container.
* [BUGFIX] [#1239](https://github.com/k8ssandra/k8ssandra-operator/issues/1239) Use `concurrent_transfers` setting from MedusaConfiguration object if it is actually set.
* [BUGFIX] [#1240](https://github.com/k8ssandra/k8ssandra-operator/issues/1240) The PullSecretRef for medusa is ignored in the standalone deployment of medusa
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue: 1.14.0 was released already and this line needs to go under a new ## unreleased section to create above.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay fixxed :)

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.2% Duplication on New Code

See analysis details on SonarCloud

@adejanovski adejanovski merged commit 9577b31 into k8ssandra:main Apr 15, 2024
59 of 60 checks passed
@tuxBurner
Copy link
Contributor Author

🥳 thanks a lot

@bradfordcp
Copy link
Member

Thank you for your contribution @tuxBurner! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adejanovski adejanovski adejanovski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The PullSecretRef for medusa is ignored in the standalone deployment of medusa
3 participants
@tuxBurner @adejanovski @bradfordcp