Fix docs check in release process (fixes #1375) #1377
Conversation
|
| ``` | ||
|
|
||
| Push the changes: | ||
| ```shell |
There was a problem hiding this comment.
[nitpick] Unrelated, but I like to double-check my commits before I push.
Separate code blocks make it easier to copy-paste the commands.
| @@ -206,7 +211,7 @@ git cherry-pick -n <your commit SHA-1s...> | |||
| Amend the merge commit with your cherry-picks: | |||
| ```shell | |||
| git add . | |||
| git commit --amend | |||
| git commit --amend --no-edit | |||
There was a problem hiding this comment.
nitpick: Not my cup of tea, I like to have the ability to edit the commit message when amending since it might be out of date. Thus, --no-edit feels odd.
There was a problem hiding this comment.
It's a merge commit though, I don't think we've ever had the need to reword it. Example
I'm going to leave it as is since it's the most common case, it's easy enough to modify the command or do another commit --amend if you want to change the message.
What this PR does:
Only use npm commands to check that the documentation builds (there's no need to install Hugo separately).
Our Hugo version is outdated, but there's no pressing need to upgrade at the moment.
Which issue(s) this PR fixes:
Fixes #1375
Checklist