Add service to expose DC nodes in the control plane (fixes #1382) #1390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olim7t
commented
Aug 22, 2024
| Spec: corev1.ServiceSpec{ | ||
| Type: corev1.ServiceTypeClusterIP, | ||
| Ports: ports, | ||
| // We don't provide a selector since the operator manages the Endpoints directly |
There was a problem hiding this comment.
I'm not sure if this service should be headless (currently it is not), it seems convenient to use the service name the contact point if a component wants to connect to "any node" in the DC.
There was a problem hiding this comment.
Actually, I think the service must be headless if we want to be able to resolve individual pod addresses.
olim7t
force-pushed
the
contact-points-service
branch
from
5f759b9
to
30846ac
Compare
5 tasks
olim7t
force-pushed
the
contact-points-service
branch
from
30846ac
to
0be32c0
Compare
rzvoncek
approved these changes
Sep 9, 2024
olim7t
force-pushed
the
contact-points-service
branch
from
d25111e
to
011c197
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Which issue(s) this PR fixes:
Fixes #1382
Checklist