Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(main): SecretSyncController split namespaces #1400

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

aGallea
Copy link
Contributor

@aGallea aGallea commented Sep 8, 2024

What this PR does:
Splits WatchNamespaces when multiple namespaces provided (WATCH_NAMESPACE)

Which issue(s) this PR fixes:
Fixes #1399

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CHANGELOG.md updated (not required for documentation PRs)
  • CLA Signed: DataStax CLA

@aGallea aGallea marked this pull request as ready for review September 9, 2024 05:51
@aGallea aGallea requested a review from a team as a code owner September 9, 2024 05:51
@aGallea
Copy link
Contributor Author

aGallea commented Sep 10, 2024

Initially opened this PR that caused the above 2 tests to fail:

unit/integration tests and build image / Run unit/integration tests
multi-cluster e2e tests / RemoveDcFromCluster
This seemed irrelevant to my changes, so I opened another PR with the same change to investigate further. However, this time, 3 different tests failed:

e2e tests / CreateSingleDseDatacenterCluster
e2e tests / CreateSingleHcdDatacenterCluster
e2e tests / PerNodeConfig/UserDefined

I'm looking for advice on how to proceed from here. Any guidance on how to debug or pinpoint the root cause would be appreciated.

@burmanm
Copy link
Contributor

burmanm commented Sep 10, 2024

They were just flakes, I reran the tests.

@burmanm
Copy link
Contributor

burmanm commented Sep 10, 2024

Any chance you could create CHANGELOG entry?

@aGallea
Copy link
Contributor Author

aGallea commented Sep 10, 2024

Any chance you could create CHANGELOG entry?

Sure

Copy link

sonarcloud bot commented Sep 10, 2024

Copy link
Contributor

@burmanm burmanm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll create a follow up ticket for proper warmup for cluster-scoped deployments.

@aGallea
Copy link
Contributor Author

aGallea commented Sep 10, 2024

@burmanm Any chance you can rerun the failed checks please?

@burmanm burmanm merged commit 08585c3 into k8ssandra:main Sep 10, 2024
62 checks passed
@burmanm
Copy link
Contributor

burmanm commented Sep 10, 2024

Thanks for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WATCH_NAMESPACE not properly splitting multiple namespaces
2 participants